now that tests passed, turn on by default, test with it off

Author: serprex

client/auth.go

@@ -210,15 +210,15 @@ func (c *Conn) writeAuthHandshake() error {
 	// Set default client capabilities that reflect the abilities of this library
 	capability := mysql.CLIENT_PROTOCOL_41 | mysql.CLIENT_SECURE_CONNECTION |
 		mysql.CLIENT_LONG_PASSWORD | mysql.CLIENT_TRANSACTIONS | mysql.CLIENT_PLUGIN_AUTH |
-		mysql.CLIENT_LONG_FLAG | mysql.CLIENT_QUERY_ATTRIBUTES
+		mysql.CLIENT_LONG_FLAG | mysql.CLIENT_QUERY_ATTRIBUTES | mysql.CLIENT_DEPRECATE_EOF
 	// Adjust client capability flags on specific client requests
 	// Only flags that would make any sense setting and aren't handled elsewhere
 	// in the library are supported here
 	capability |= c.ccaps&mysql.CLIENT_FOUND_ROWS | c.ccaps&mysql.CLIENT_IGNORE_SPACE |
 		c.ccaps&mysql.CLIENT_MULTI_STATEMENTS | c.ccaps&mysql.CLIENT_MULTI_RESULTS |
 		c.ccaps&mysql.CLIENT_PS_MULTI_RESULTS | c.ccaps&mysql.CLIENT_CONNECT_ATTRS |
 		c.ccaps&mysql.CLIENT_COMPRESS | c.ccaps&mysql.CLIENT_ZSTD_COMPRESSION_ALGORITHM |
-		c.ccaps&mysql.CLIENT_LOCAL_FILES | c.ccaps&mysql.CLIENT_DEPRECATE_EOF
+		c.ccaps&mysql.CLIENT_LOCAL_FILES
 
 	capability &^= c.clientExplicitOffCaps
 

client/client_test.go

@@ -101,6 +101,18 @@ func (s *clientTestSuite) TestConn_Compress() {
 	require.NoError(s.T(), err)
 }
 
+func (s *clientTestSuite) TestConn_NoDeprecateEOF() {
+	addr := fmt.Sprintf("%s:%s", *test_util.MysqlHost, s.port)
+	conn, err := Connect(addr, *testUser, *testPassword, "", func(conn *Conn) error {
+		conn.UnsetCapability(mysql.CLIENT_DEPRECATE_EOF)
+		return nil
+	})
+	require.NoError(s.T(), err)
+
+	_, err = conn.Execute("SELECT VERSION()")
+	require.NoError(s.T(), err)
+}
+
 func (s *clientTestSuite) TestConn_SetCapability() {
 	caps := []uint32{
 		mysql.CLIENT_LONG_PASSWORD,
@@ -125,6 +137,7 @@ func (s *clientTestSuite) TestConn_SetCapability() {
 		mysql.CLIENT_PLUGIN_AUTH,
 		mysql.CLIENT_CONNECT_ATTRS,
 		mysql.CLIENT_PLUGIN_AUTH_LENENC_CLIENT_DATA,
+		mysql.CLIENT_DEPRECATE_EOF,
 	}
 
 	for _, capI := range caps {