Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URGENT: Embedded structs #29

Open
frederikhors opened this issue Dec 8, 2020 · 2 comments
Open

URGENT: Embedded structs #29

frederikhors opened this issue Dec 8, 2020 · 2 comments

Comments

@frederikhors
Copy link
Contributor

frederikhors commented Dec 8, 2020 •
edited
Loading

What I miss using this instead of https://github.com/leebenson/conform is the check of embedded structs:
https://github.com/leebenson/conform/blob/master/conform.go#L272.

Can we add this?

Maybe optional (default: true) with a tag: mod:"embedded=false".

What do you think?

This is URGENT IMO because I cannot use it having a lot of embedded structs.
@frederikhors frederikhors changed the title Embedded structs URGENT: Embedded structs Dec 8, 2020
@deankarn
Copy link
Contributor

I'm not sure I understand how this feature is intended to work, can you provide a code sample?

@frederikhors
Copy link
Contributor Author

Oh. Maybe I don't know how to use dive. I will update this issue as soon as I understand it. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@deankarn @frederikhors