Lazily initialize regexes to speed up init()
#1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `GODEBUG=inittrace=1` I found a relatively constant 10ms init caused by this function. Replaces go-playground#1246.
|
@deankarn sorry for the PR spam, other one automatically closed! 🤦 I changed this to use |
kylecarbs
changed the title
init()
deankarn
approved these changes
Jun 12, 2024
nieomylnieja
added a commit
to nobl9/govy
that referenced
this pull request
Sep 19, 2024
## Motivation We should aim at limiting initial load time when importing the library, one of the contributors to the initial load time are compilations of regular expressions. We should avoid loading all of them at once, but rather lazy load the ones which are used by users once. ## Related Changes go-playground/validator#1277 ## Release Notes All regular expressions are now lazy loaded, once when the corresponding rule is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
GODEBUG=inittrace=1I found a relatively constant 10ms init caused by this function.Replaces #1246.
@go-playground/validator-maintainers