Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images not being archived #244

Closed
vorkuta opened this issue Apr 28, 2020 · 5 comments
Closed

Images not being archived #244

vorkuta opened this issue Apr 28, 2020 · 5 comments
Labels
component:readability type:bug Something isn't working

Comments

@vorkuta
Copy link

vorkuta commented Apr 28, 2020

Have installed the latest release of 18.04 - shiori-linux-amd64-stretch

Most of the links do not seem to be saving images when addings.

link

The first time I loaded this, the first image loaded. The second time (redownloaded) and I lost all of the images. I had a search of the GitHub images, but it said it had been fixed.

@8bitgentleman
Copy link

I just tried the same link on my fresh docker install and Shiori got all of the images just fine

@vorkuta
Copy link
Author

vorkuta commented Apr 29, 2020

I'm running shiori-linux-amd64-stretch from precompiled binary, not a docker install, but thanks for the input.

@vorkuta
Copy link
Author

vorkuta commented Apr 29, 2020

As an update, had a look at the source html for this specific content view.

<img data-pin-title="Oaxacan Lamb Barbacoa!" src="data:image/svg+xml,%3Csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%20750%201125'%3E%3C/svg%3E" alt="Mexican Lamb Barbacoa - a simple delicious recipe from Oaxaca that results in tender, juicy falling off the bone lamb perfect for tacos and burritos! #tacos #barbacoa #lamb #lambrecipes #oaxaca #mexicanrecipes #cincodemayo " data-pin-description="Mexican Lamb Barbacoa - a simple delicious recipe from Oaxaca that results in tender, juicy falling off the bone lamb perfect for tacos and burritos! #tacos #barbacoa #lamb #lambrecipes #oaxaca #mexicanrecipes #cincodemayo " data-lazy-src="https://www.feastingathome.com/wp-content/uploads/2019/04/Lamb-Barbacao-Recipe-116.jpg" srcset="" width="750" height="1125">

I don't know what the difference is between src and data-lazy-src, but there may be an issue with the src?

src="data:image/svg+xml,%3Csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%20750%201125'%3E%3C/svg%3E"

If anyone has some examples of how image code is supposed to lookl that would be appreciated.

@vorkuta
Copy link
Author

vorkuta commented Apr 29, 2020

If it's relevant, I don't know if exerpts are supposed to be displayed on the main bookmark list/tile view, but I only the image, title, url etc., can't see an exerpt. Image attached.

shiori

@fmartingr fmartingr added type:bug Something isn't working component:readability labels Feb 6, 2022
@fmartingr
Copy link
Member

Any problem with the archives will get worked on with the switch to obelisk #353. After the switch, we can start fixing things directly on obelisk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readability type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants