-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dial timeout? #85
Comments
you're right. |
May be as simple as removing the check and return at Line 236 in 59e906c
Also, thanks so much for doing this, it's saving me a lot of pain trying to build my app for other architectures. No CGO is a win! |
This is a better reference: https://rfc.zeromq.org/spec/23/#socket-semantics |
Hi! At the moment the user facing .Dial is synchronous. This should be kept that way. The spec talks about "reconnect", which in my view is something different from the initial connect. I would opt for the following:
While implementing 1. I'd like to add a context.Context to the .Dial methods or add a .DialContext method. Cheers |
I think that the numbers of retries should be configurable, if the user sets it to infinite (could be -1 or so) then the behavior will be very similar to the libzmq implementation, while still being synchronous |
sure, why not. |
yes, I think I could. Not sure when I will have time for it, though |
I don't think ZMQ connects should be timing out like you are doing. See http://api.zeromq.org/4-1:zmq-connect, the whole point is that pub/sub/bind/connect order doesn't matter. pebbe/zmq4 does not time out on connect/Dial.
The text was updated successfully, but these errors were encountered: