Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency Tracker 1.3.1.1 #2808

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Currency Tracker 1.3.1.1 #2808

merged 3 commits into from
Nov 3, 2023

Conversation

AtmoOmen
Copy link
Contributor

  • Completely cleaned and reorganized the current code of the plugin, ensuring more reliable operation.
  • Organized the current localization strings and optimized the logic for reading localized texts.
  • Optimized the current currency reading logic to better accommodate the needs of users who switch client languages.
  • Optimized the logic for storing and reading currency data.
  • Optimized the Gold Saucer related features logic to prevent unexpected transactions modifications.
  • Optimized the plugin operation logic when in duty.
  • Fixed the issue where the table toolbar Merge function couldn't input properly.
  • Fixed the issue where the table toolbar Edit function displayed the modification location successfully after modifying the Note.
  • Fixed the issue where the table toolbar Copy function still copied text to the clipboard when no transactions were selected.
  • Fixed the issue of header loss when exporting .csv files under Simplified Chinese.
  • Fixed the issue of partial loss of English localization texts.
  • Fixed the issue of Gold Sacuer inability to correctly track currencies other than MGP.
  • Modified the logic of the Awaiting Exchange Completion function, which should result in significant performance improvements.
  • Added source tracking for rewards in the Leap of Faith and Air Force One mini-games.
  • Added win-loss tracking for the Triple Triad match rewards.

@bleatbot bleatbot enabled auto-merge (squash) October 30, 2023 13:50
@bleatbot
Copy link
Collaborator

bleatbot commented Oct 30, 2023

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently more than a day.

✔️CurrencyTracker [stable] - 61eb49e - v1.3.1.0 - Diff (738 lines, prev. 1.3.0.2)

Show log - Review

@bleatbot bleatbot added the size-mid Diff for this PR is mid-sized. label Oct 30, 2023
auto-merge was automatically disabled November 1, 2023 12:16

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 1, 2023

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️CurrencyTracker [stable] - 1085bc9 - v1.3.1.1 - Diff (2159 lines, prev. 1.3.0.2)

Show log - Review

@bleatbot bleatbot added size-large Diff for this PR is large. and removed size-mid Diff for this PR is mid-sized. labels Nov 1, 2023
@AtmoOmen AtmoOmen changed the title Currency Tracker 1.3.1.0 Currency Tracker 1.3.1.1 Nov 1, 2023
@AtmoOmen
Copy link
Contributor Author

AtmoOmen commented Nov 1, 2023

1.3.1.1

  • Optimized the code logic for Record Trade Target feature.
  • Improved performance when searching for items in Custom Currency Tracker for reduced performance consumption.
  • Fixed an issue where, in Simplified Chinese, it was only possible to search for items in Custom Currency Tracker by entering Pinyin.
  • Added Icon Display to the currency listbox.
  • Added Rename currencies feature.
  • Added Traditional Chinese, Spanish and German localization text.

Most of diffs are from localization .resx files.

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 2, 2023

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️CurrencyTracker [stable] - afff1a6 - v1.3.1.1 - Diff (2819 lines, prev. 1.3.0.2)

Show log - Review

@AtmoOmen
Copy link
Contributor Author

AtmoOmen commented Nov 3, 2023

hey, @lmcintyre, bleatbot didn't merge automatically.

@reiichi001 reiichi001 merged commit 81f393b into goatcorp:main Nov 3, 2023
2 checks passed
@AtmoOmen AtmoOmen deleted the patch-1 branch November 3, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-large Diff for this PR is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants