Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Launcher keeps running after closing the window, if patching is in progress #209

Closed
ghost opened this issue Dec 20, 2024 · 3 comments
Closed

Comments

@ghost
Copy link

ghost commented Dec 20, 2024

Screencast_20241220_140826.webm

I noticed that if I close the window using the "X" button at the top right, the application closes appropriately.
However, if I do it while patching is in progress, it doesn't.

The video shows the expected behavior in comparison will closing a simple Firefox window.

This behavior is the same with both Flatpak and AUR.

Probably similar to #174

Edit: This issue goes away when I use the fork with the RB patches.

@ghost
Copy link
Author

ghost commented Dec 20, 2024

I cloned the repo, installed everything with submodules and published the app as is, and cannot reproduce the problem. I'm not sure if this is something specific with the way both AUR and Flatpak versions handle exiting during patching.

@rankynbass
Copy link
Contributor

rankynbass commented Dec 20, 2024

This was fixed in PR192, which was merged after the latest release. This will be fixed in 1.1.2 or whatever version comes next.

@ghost
Copy link
Author

ghost commented Dec 20, 2024

Thank you! 🥰 Closing this as it was fixed.

@ghost ghost closed this as completed Dec 20, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant