You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is special-cased for the runtime version originally shipped (5.0.6), and looks up if any current Dalamud version is using this runtime version (I think?). However, this is flawed, as XL will make this request with the local runtime/version file, which may be a version no longer (but previously) used by Dalamud (6.0.6, in this scenario). This resulted in a user unable to update Dalamud, as DalamudUpdater was failing in DalamudUpdater.CheckRuntimeHashes.
attempt the request to dalamud-distrib and then 400 if it fails, noting the file does not exist
create a metadata file in dalamud-distrib containing a list of version with hashes, which is then cached (prevents a bad actor from spamming invalid version numbers which get proxied to GitHub)
remove the runtime folder if the request 400's in XL
The text was updated successfully, but these errors were encountered:
Observe the start of ReleaseController.Runtime:
This is special-cased for the runtime version originally shipped (5.0.6), and looks up if any current Dalamud version is using this runtime version (I think?). However, this is flawed, as XL will make this request with the local
runtime/version
file, which may be a version no longer (but previously) used by Dalamud (6.0.6, in this scenario). This resulted in a user unable to update Dalamud, as DalamudUpdater was failing in DalamudUpdater.CheckRuntimeHashes.The hashes are still present in dalamud-distrib, so it doesn't make much sense to throw here. I propose one of
The text was updated successfully, but these errors were encountered: