From a5ab08b1a744f647ea4ef86a24173b6d545c103f Mon Sep 17 00:00:00 2001
From: Simmo Saan <simmo.saan@gmail.com>
Date: Wed, 24 Jul 2024 17:27:39 +0300
Subject: [PATCH] Remove unused goblint.build-info and goblint.sites dependency
 from most executables

---
 gobview                        | 2 +-
 src/dune                       | 8 ++++----
 src/index.mld                  | 6 ------
 tests/regression/cfg/util/dune | 4 +---
 tests/unit/dune                | 2 +-
 tests/util/dune                | 4 +---
 6 files changed, 8 insertions(+), 18 deletions(-)

diff --git a/gobview b/gobview
index f9ce8bcad3..4e965cf1bb 160000
--- a/gobview
+++ b/gobview
@@ -1 +1 @@
-Subproject commit f9ce8bcad3552ad95488bc4988dcc0d5ed57b365
+Subproject commit 4e965cf1bb7be5e7ceef2a40586ea445682cca64
diff --git a/src/dune b/src/dune
index c549fd5d7d..2ba497c629 100644
--- a/src/dune
+++ b/src/dune
@@ -88,7 +88,7 @@
   (public_names goblint)
   (modes byte native) ; https://dune.readthedocs.io/en/stable/dune-files.html#linking-modes
   (modules goblint)
-  (libraries goblint.lib goblint.sites goblint.build-info goblint_std)
+  (libraries goblint.lib goblint_std)
   (preprocess (pps ppx_deriving.std ppx_deriving_hash ppx_deriving_yojson))
   (flags :standard -linkall -open Goblint_std)
 )
@@ -96,7 +96,7 @@
 (executable
   (name privPrecCompare)
   (modules privPrecCompare)
-  (libraries goblint.lib goblint.sites goblint.build-info goblint_std)
+  (libraries goblint.lib goblint_std)
   (preprocess (pps ppx_deriving.std ppx_deriving_hash ppx_deriving_yojson))
   (flags :standard -linkall -open Goblint_std)
 )
@@ -104,7 +104,7 @@
 (executable
   (name apronPrecCompare)
   (modules apronPrecCompare)
-  (libraries goblint.lib goblint.sites goblint.build-info goblint_std)
+  (libraries goblint.lib goblint_std)
   (preprocess (pps ppx_deriving.std ppx_deriving_hash ppx_deriving_yojson))
   (flags :standard -linkall -open Goblint_std)
 )
@@ -112,7 +112,7 @@
 (executable
   (name messagesCompare)
   (modules messagesCompare)
-  (libraries goblint.lib goblint.sites goblint.build-info goblint_std)
+  (libraries goblint.lib goblint_std)
   (preprocess (pps ppx_deriving.std ppx_deriving_hash ppx_deriving_yojson))
   (flags :standard -linkall -open Goblint_std)
 )
diff --git a/src/index.mld b/src/index.mld
index f0d63a0fc7..a2ef15482e 100644
--- a/src/index.mld
+++ b/src/index.mld
@@ -44,15 +44,9 @@ The following libraries provide [goblint] package metadata for executables.
 
 {2 Library goblint.build-info}
 {!modules:Goblint_build_info}
-This library is virtual and has the following implementations
-- goblint.build-info.dune for native executables,
-- goblint.build-info.js for js_of_ocaml executables.
 
 {2 Library goblint.sites}
 {!modules:Goblint_sites}
-This library is virtual and has the following implementations
-- goblint.sites.dune for native executables,
-- goblint.sites.js for js_of_ocaml executables.
 
 
 {1 Independent utilities}
diff --git a/tests/regression/cfg/util/dune b/tests/regression/cfg/util/dune
index 4c41de07e4..8ab300b531 100644
--- a/tests/regression/cfg/util/dune
+++ b/tests/regression/cfg/util/dune
@@ -5,7 +5,5 @@
    goblint_logs
    goblint_common
    goblint_lib ; TODO: avoid: extract LoopUnrolling and WitnessUtil node predicates from goblint_lib
-   fpath
-   goblint.sites
-   goblint.build-info)
+   fpath)
  (preprocess (pps ppx_deriving.std)))
diff --git a/tests/unit/dune b/tests/unit/dune
index 6c3083dc1a..07c87e7822 100644
--- a/tests/unit/dune
+++ b/tests/unit/dune
@@ -2,7 +2,7 @@
 
 (test
   (name mainTest)
-  (libraries ounit2 qcheck-ounit goblint.std goblint.common goblint.lib goblint.constraint goblint.solver goblint.cdomain.value goblint.sites goblint.build-info)
+  (libraries ounit2 qcheck-ounit goblint.std goblint.common goblint.lib goblint.constraint goblint.solver goblint.cdomain.value)
   (preprocess (pps ppx_deriving.std ppx_deriving_hash ppx_deriving_yojson))
   (flags :standard -linkall))
 
diff --git a/tests/util/dune b/tests/util/dune
index fb630bd15b..d37c38dc7c 100644
--- a/tests/util/dune
+++ b/tests/util/dune
@@ -4,8 +4,6 @@
    batteries.unthreaded
    goblint_std
    goblint_lib
-   yaml
-   goblint.sites
-   goblint.build-info)
+   yaml)
  (flags :standard -open Goblint_std)
  (preprocess (pps ppx_deriving.std)))