You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
so i've noticed that if you do a buffalo build --mod vendor ... you will find that buffalo calls go mod tidy a few times - which may not be desired if you're using a vendor folder (or it wasn't for me)
Expected Behavior
If i'm setting mod to vendor, I probably do not want buffalo to actively tidy things
Actual Behavior
buffalo rungs go mod tidy twice
Potential fix
To Reproduce
Do something like buffalo build --mod vendor -v --static --clean-assets -o /bin/app and watch it download things that are already in the vendor folder.
Additional Context
I created a small patch to the cli where if it detects that the opts.Mod is set to vendor it will skip the go mod tidy calls. Perhaps this is clunky, but at the same time it might be reasonable. Let me know if I should submit it.
The text was updated successfully, but these errors were encountered:
venezia
changed the title
bug:
bug: go mod tidy runs when --mod vendor is set in buffalo build command
Sep 15, 2023
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Description
so i've noticed that if you do a
buffalo build --mod vendor ...
you will find that buffalo callsgo mod tidy
a few times - which may not be desired if you're using a vendor folder (or it wasn't for me)Expected Behavior
If i'm setting mod to vendor, I probably do not want buffalo to actively tidy things
Actual Behavior
buffalo rungs
go mod tidy
twicePotential fix
To Reproduce
Do something like
buffalo build --mod vendor -v --static --clean-assets -o /bin/app
and watch it download things that are already in the vendor folder.Additional Context
I created a small patch to the cli where if it detects that the
opts.Mod
is set tovendor
it will skip thego mod tidy
calls. Perhaps this is clunky, but at the same time it might be reasonable. Let me know if I should submit it.The text was updated successfully, but these errors were encountered: