You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe that there are two things that need to be made public:
type Decoder interface {
getCSVRows() ([][]string, error) // This method is currently private
}
func readTo(decoder Decoder, out interface{}) error // Making this function public
I can submit a pull request but I want to make sure that you are happy with the change and if you are happy with it, I want to collect feedbacks on how you would like to interface to look like before starting work on it
I don't see any problems for making these two things public.
As for the interface, does it need to change? Just making the method getCSVRows() ([][]string, error) public is not enough?
I have a use case where I already have the csv rows in memory as [][]string. So I no longer need to parse strings.
And primarily I would like to be able to implement a custom decoder and leverage the readTo function to populate fields into the my structs.
The text was updated successfully, but these errors were encountered: