Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Date] Implement %p, improve token composition, fix leading-space parsers/formatters, improve error messages, slurp whitespace #166

Merged
merged 5 commits into from
Mar 10, 2024

Conversation

ohaibbq
Copy link
Contributor

@ohaibbq ohaibbq commented Feb 6, 2024

Closes #165
Closes #151
Closes #167

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2024

Codecov Report

Merging #166 (d23192f) into main (961ce06) will increase coverage by 0.68%.
Report is 12 commits behind head on main.
The diff coverage is 80.76%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   46.39%   47.07%   +0.68%     
==========================================
  Files          47       47              
  Lines       17828    17840      +12     
==========================================
+ Hits         8271     8399     +128     
+ Misses       8111     7991     -120     
- Partials     1446     1450       +4     

@ohaibbq ohaibbq changed the title [Date] Implement %p, improve token composition, fix leading-space parsers/formatters WIP: [Date] Implement %p, improve token composition, fix leading-space parsers/formatters Feb 14, 2024
@ohaibbq ohaibbq changed the title WIP: [Date] Implement %p, improve token composition, fix leading-space parsers/formatters [Date] Implement %p, improve token composition, fix leading-space parsers/formatters, improve error messages, slurp whitesppace Feb 21, 2024
@ohaibbq ohaibbq changed the title [Date] Implement %p, improve token composition, fix leading-space parsers/formatters, improve error messages, slurp whitesppace [Date] Implement %p, improve token composition, fix leading-space parsers/formatters, improve error messages, slurp whitespace Feb 21, 2024
@goccy
Copy link
Owner

goccy commented Mar 9, 2024

Please fix the error from linter

@goccy goccy added the reviewed label Mar 9, 2024
Copy link
Owner

@goccy goccy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your awesome PR !!! LGTM 👍

@goccy goccy merged commit 8af7089 into goccy:main Mar 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants