[Aggregate] Correctly handle ordering multiple fields; don't crash on nil #174
+70
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
+ Coverage 46.39% 47.15% +0.76%
==========================================
Files 47 47
Lines 17828 17876 +48
==========================================
+ Hits 8271 8430 +159
+ Misses 8111 7983 -128
- Partials 1446 1463 +17 |
goccy
reviewed
Mar 9, 2024
query_test.go
Outdated
| name: "array_concat_agg with null in order by", | ||
| query: `WITH toks AS (SELECT ['1'] AS x, '1' as y UNION ALL SELECT ['2', '3'], null) SELECT ARRAY_CONCAT_AGG(x ORDER BY y) FROM toks`, | ||
| expectedRows: [][]interface{}{{ | ||
| []interface{}{"3", "2", "1"}, |
There was a problem hiding this comment.
I tried this query in the BigQuery Console and got results 2, 3, 1 .
What do you think about this?
There was a problem hiding this comment.
2, 3, 1 seems correct. I'll take a look at what's going on.
|
It looks like there was also previously a bug with |
goccy
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145
Closes goccy/bigquery-emulator#198
Closes #144