Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for authentication/search timeout #2

Open
bdpiprava opened this issue Dec 15, 2016 · 0 comments
Open

Add support for authentication/search timeout #2

bdpiprava opened this issue Dec 15, 2016 · 0 comments

Comments

@bdpiprava
Copy link
Contributor

bdpiprava commented Dec 15, 2016

Issue Type
  • Bug Report
Summary

LdapUserSearch is hard coding the LDAP search timelimit parameter which prevents the administrator from tuning this parameter as appropriate for their environment.

I believe this is normally handled by the system property com.sun.jndi.ldap.read.timeout .

Steps to Reproduce
  1. Find an LDAP server with over 100,000 entries with 'memberOf' overlay enabled
  2. Add an LDAP filter in GoCD to use memberOf
  3. wait 6 seconds
Expected Results
  • Slow but working response
Actual Results
  • Soft sobbing
Possible Fix
  • Remove line 90 in above referenced file
Any other info
  • I really do like you guys. Ignore the snark.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant