Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specs: Memberships - restriction_page_id and restriction_url should mimick sales_page_page_id and sales_page_url props. #134

Open
eri-trabiccolo opened this issue Oct 30, 2019 · 0 comments
Open

Specs: Memberships - restriction_page_id and restriction_url should mimick sales_page_page_id and sales_page_url props. #134

eri-trabiccolo opened this issue Oct 30, 2019 · 0 comments
Labels
Type: Bug Bugs and errors Type: Documentation Issue related to documentation Type: Question This issue is a question

Comments

@eri-trabiccolo
Copy link
Contributor

Meaning that, as for the similar sales_page_* props:
restriction_page_id should only be returned when restriction_action equals page or context is edit (see also #133)
restriction_page_url should only be returned when restriction_action equals custom or context is edit (see also #133)

@pondermatic memberships PR already follows this logic:
https://github.com/gocodebox/lifterlms-rest/pull/120/files#diff-275b00ffb29cfbbf3de122e50d64cdedR496-R503
@eri-trabiccolo eri-trabiccolo added Type: Question This issue is a question Type: Documentation Issue related to documentation Type: Bug Bugs and errors labels Oct 30, 2019
@thomasplevy thomasplevy moved this to Awaiting Triage in Development Apr 21, 2022
@thomasplevy thomasplevy moved this from Awaiting Triage to Backlog in Development Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Bugs and errors Type: Documentation Issue related to documentation Type: Question This issue is a question
Projects
Development
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eri-trabiccolo