Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if no remote validator was specified #602

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Warn if no remote validator was specified #602

wants to merge 5 commits into from

Conversation

koplas
Copy link
Contributor

@koplas koplas commented Dec 4, 2024 •
edited
Loading

Prints a warning if no remote validator was configured.

Closes #601

s-l-teichmann
s-l-teichmann previously approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@s-l-teichmann s-l-teichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @koplas I have reworked the exit code doc part to make it more clear that the bits are superposed .. Its a bit technical .. so if you have a better wording?

@koplas
Copy link
Contributor Author

koplas commented Dec 4, 2024

LGTM @koplas I have reworked the exit code doc part to make it more clear that the bits are superposed .. Its a bit technical .. so if you have a better wording?

Most documentations have a table with a Hex Mask, but this is even more technical. This approach seems good enough for me.

@koplas koplas requested a review from JanHoefelmeyer December 6, 2024 12:14
bernhardreiter
bernhardreiter requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@bernhardreiter bernhardreiter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a return from run() with error condition set with lead to os.exit(1), but 1 always means exitCodeSchemaInvalid so each codepath for this should be checked and either commented or changed.

@koplas
Copy link
Contributor Author

koplas commented Dec 16, 2024

I just noticed the documentation for the exit code is wrong. x % 1 never equals 1.

@bernhardreiter
Copy link
Member

To get this consistent:

Do we have a first bit set in all error cases (like the documentation suggests) or only when there is no other error?

Do we have the other bits set in case of general error?

Do we get log output on all errors or only on general errors (as the documentation suggests)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-l-teichmann s-l-teichmann s-l-teichmann left review comments

@JanHoefelmeyer JanHoefelmeyer Awaiting requested review from JanHoefelmeyer

@bernhardreiter bernhardreiter Awaiting requested review from bernhardreiter

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

csaf_validator: Warn if remote_validator is not configured
3 participants
@koplas @bernhardreiter @s-l-teichmann