Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code can be greatly simplified by using new HSV support in Jetpack #69

Open
jonsmirl opened this issue May 8, 2023 · 1 comment
Open

Code can be greatly simplified by using new HSV support in Jetpack #69

jonsmirl opened this issue May 8, 2023 · 1 comment

Comments

@jonsmirl
Copy link

jonsmirl commented May 8, 2023 •
edited
Loading

Google has added HSV support to Color.
https://developer.android.com/reference/kotlin/androidx/compose/ui/graphics/Color#hsv(kotlin.Float,kotlin.Float,kotlin.Float,kotlin.Float,androidx.compose.ui.graphics.colorspace.Rgb)

All of the conversions to SRGB are built in to Color.
@jonsmirl jonsmirl changed the title Code can be greatly simplified by using new HLS support in Jetpack Code can be greatly simplified by using new HSV support in Jetpack May 8, 2023
@sproctor
Copy link
Contributor

sproctor commented Feb 4, 2024

I don't see a function to convert from Color to HSV. The only thing that I see that can be simplified is HsvColor.toColor().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonsmirl @sproctor