Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify string parameters across all builders #996

Open
chitoyuu opened this issue Dec 7, 2022 · 0 comments · May be fixed by #1037
Open

Unify string parameters across all builders #996

chitoyuu opened this issue Dec 7, 2022 · 0 comments · May be fixed by #1037
Labels
breaking-change Issues and PRs that are breaking to fix/merge. c: export Component: export (mod export, derive) quality-of-life No new functionality, but improves ergonomics/internals
Milestone

Comments

@chitoyuu
Copy link
Contributor

chitoyuu commented Dec 7, 2022

Created during survey of commented code (#377).

As of Rust 1.63.0, the turbofish syntax can now be used along with impl Trait: https://blog.rust-lang.org/2022/08/11/Rust-1.63.0.html#turbofish-for-generics-in-functions-with-impl-trait

As such, we now have more freedom to use types like impl Into<GodotString> or impl Into<Cow<'a, str>> where we need to take string arguments (for names) along with explicit type arguments in builders.

This may still constitute a breaking change, if a technical one.

@chitoyuu chitoyuu added c: export Component: export (mod export, derive) breaking-change Issues and PRs that are breaking to fix/merge. quality-of-life No new functionality, but improves ergonomics/internals labels Dec 7, 2022
@chitoyuu chitoyuu added this to the v0.12.0 milestone Jan 4, 2023
@chitoyuu chitoyuu linked a pull request Feb 22, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Issues and PRs that are breaking to fix/merge. c: export Component: export (mod export, derive) quality-of-life No new functionality, but improves ergonomics/internals
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant