-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't submit icon url that ends in ?raw=true #314
Comments
GitHub repositories provide compatible links. In fact, the one that you've submitted is redirected to one: (although it's preferable if you use one from a specific commit hash rather than from the master to avoid changing it unexpectedly for users). |
We could perform the redirect on our end automatically (using a regex), so you don't have to do it yourself when submitting the asset. |
I know you're doing a redesign - it might be better in the new design for you to just host everything so you're not reliant on external sites. But also, perhaps have your regex just ignore everything after the ? could work too. |
Hey folks - I'm bringing this thread back from the dead because as of the current version of GitHub's raw URLs, the Asset Library no longer allows the only form of raw URLs ( I'm not in the loop about any sort of site redesign (if that happened already or not), but hopefully this change could be implemented soon regardless! If I have spare time I might cook up a PR. |
I'm trying to submit to the asset library using the Custom method. I need to provide a URL to an icon. I want to provide a link to one uploaded to my Github page, but it's being rejected because it ends in ?raw=true instead of .png. Could the code allow for an exception for this from github repositories?
Same for anything I might upload to google drive. They don't end in .png either.
The text was updated successfully, but these errors were encountered: