You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Which demo project is affected:
All possibly to clean.
Description:
Could be interesting to add a pre commit hook to clean commits before pull requests and add it to recommended guidelines.
Would make smoother I think the review process.
This is a good idea, yeah. We already have this for the engine repo, having pre-commit here too would be nice. At a minimum it could perform the same basic checks as CI, at best it could perform more formatting.
Note that, as seen in #1085, the proposed linter does not correctly follow the GDScript style guide, so it'd have to be improved to properly handle that before it can be used here
Which demo project is affected:
All possibly to clean.
Description:
Could be interesting to add a pre commit hook to clean commits before pull requests and add it to recommended guidelines.
Would make smoother I think the review process.
Resources:
https://pre-commit.com/
https://github.com/Scony/godot-gdscript-toolkit/blob/master/.pre-commit-hooks.yaml
For context I got the idea with this review
#1085
The text was updated successfully, but these errors were encountered: