Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not support Chinese symbol jump #705

Open
wayrboy opened this issue Sep 3, 2024 · 6 comments
Open

Do not support Chinese symbol jump #705

wayrboy opened this issue Sep 3, 2024 · 6 comments
Labels

Comments

@wayrboy
Copy link

wayrboy commented Sep 3, 2024

Godot version

4.3stable

VS Code version

1.86.1

Godot Tools VS Code extension version

2.1

System information

windows 11

Issue description

621d7d92d919b74ce05bfe105e7339f3

Steps to reproduce

621d7d92d919b74ce05bfe105e7339f3

@wayrboy wayrboy added the bug label Sep 3, 2024
@Calinou
Copy link
Member

Calinou commented Sep 6, 2024

Do you mean Ctrl + clicking does not work on identifiers that are in Chinese?

@DaelonSuzuka
Copy link
Collaborator

@wayrboy Please at least paste your example code so I can try and reproduce the problem.

@wayrboy
Copy link
Author

wayrboy commented Sep 20, 2024

@Calinou yes

@wayrboy
Copy link
Author

wayrboy commented Sep 20, 2024

@DaelonSuzuka

extends Label

class 工作类:
var 目标次数 = 0

class test:
var t = 0

var 工作 = 工作类.new()

var t = test.new()

does not work on identifiers that are in Chinese

@wayrboy
Copy link
Author

wayrboy commented Sep 26, 2024

@DaelonSuzuka
image
image

After studying for a while, adding some rules to regular expressions can solve the problem of high grammar, but it still has not solved the problem of fast jump. Please tell me what to do

@DaelonSuzuka
Copy link
Collaborator

I cannot fix the fast jump feature because that's provided by the Language Server, which is a part of the Engine.

I'm still thinking about the right way to fix the syntax highlighting, because if I make that change, I will also have to make it in hundreds of other rules, and I won't do that without being certain what the effects will be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants