Cleaner, faster StringBuilder implementation #77152
Conversation
| // -1 means it's a Godot String | ||
| // a natural number means C string. | ||
| Vector<int32_t> appended_strings; | ||
| char32_t *buffer; | ||
|
|
There was a problem hiding this comment.
Maybe you can just use a LocalVector instead of handling memory internally? This whole class seems much like a wrapper on LocalVector. 🤔
There was a problem hiding this comment.
That would actually just increase the code size, and force me to double-check that every assumption holds for the specific method calls I use. And would be susceptible to future changes in LocalVector. I refer you to the story of how left-pad took down the internet. Not everything has to be a web of inter-dependencies.
At any rate the discussion is moot. It turns out there's another class called StringBuffer that does everything this naive implementation does, plus a couple of extras, achieving better performance on benchmarks. So an even smaller solution would be to just typedef StringBuilder to StringBuffer. Or remove use of the prior from the code completely.
|
Superseded by #77158 |
Reimplements
StringBuilderusing a single exponentially growing character buffer, instead of 3 separate arrays of strings. According to benchmarks, this achieves around a 5-7 times boost in performance. And it does it with fewer lines of code.