Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin dependency management in cmake #774

Closed
James-Mart opened this issue Jul 5, 2024 · 0 comments
Closed

Fix plugin dependency management in cmake #774

James-Mart opened this issue Jul 5, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@James-Mart
Copy link
Member

James-Mart commented Jul 5, 2024

Since changing from custom command/target to ExternalProject_Add for adding rust components (plugins) to the build system, I broke the management of the build order when plugins depend on each other:

https://github.com/gofractally/psibase/pull/656/files?diff=split&w=0

One idea to fix it is to add some top-level cargo project that adds all plugins as members of the same workspace, then in CMake we just add that one rust crate as the external project that manages building all subprojects.

@James-Mart James-Mart added the bug Something isn't working label Jul 5, 2024
@James-Mart James-Mart self-assigned this Jul 5, 2024
@github-project-automation github-project-automation bot moved this to Done in Psibase Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

1 participant