Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli alters generated files #397

Open
wood-jp opened this issue Sep 13, 2022 · 2 comments
Open

cli alters generated files #397

wood-jp opened this issue Sep 13, 2022 · 2 comments

Comments

@wood-jp
Copy link

wood-jp commented Sep 13, 2022

Repo contains generated code that helpfully starts with

// Code generated - DO NOT EDIT.

Running the cli renames these files to foo.go.grc.bk and then leaves them like this.

I would expect that the report card should not actually alter any files in anyway.

@geertjanvdk
Copy link

I believe that the idea is that goreportcard as a services clones the repository and does whatever it pleases with it. This is fine. However, goreportcard-cli suffers from this.

The workaround would be to clone temporary, and then run report on that. That's a pain, but valid workaround.

Greater would to actually rename the files back that were skipped. Maybe a fork of this project has already done this? I have clone the repository, maybe I can figure something out.

@thediveo
Copy link

thediveo commented Mar 30, 2024

Sorry, but goreportcard-cli can be run at any time on a working repo in order to find issues during development. So renaming generated code is just bad behavior; you can try to find some excuses for it, but it is simply still bad behavior. For your benefit, I'm adding here a screenshot of the README below; there is nothing to support the above hypothesis.

goreportcard README CLI

shawnps added a commit that referenced this issue Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants