Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 Inconsistent Behaviours (one works; the other two fail) #418

Open
texadactyl opened this issue Dec 31, 2023 · 2 comments
Open

3 Inconsistent Behaviours (one works; the other two fail) #418

texadactyl opened this issue Dec 31, 2023 · 2 comments

Comments

@texadactyl
Copy link

texadactyl commented Dec 31, 2023

[1] On the web, my github site (https://goreportcard.com/report/github.com/texadactyl/jacotest.go), gets the common failure that many people are reporting:

There was an error processing your request: Could not analyze the repository: no .go files found

This is a strange result because there are plenty of .go files if the operational code simply walked the tree.

[2] When I follow the local installation instructions and run it from the command line, it works as expected. Success!

[3] When I try the README.md instructions for running as a local web application,
GRC_DATABASE_PATH=./db make start
I see the following:

vendor/github.com/dgraph-io/badger/v2/backup.go:26:2: cannot find module providing package github.com/dgraph-io/badger/v2/pb: import lookup disabled by -mod=vendor
	(Go version in go.mod is at least 1.14 and vendor directory exists.)

In my opinion, I should not have to perform a local install in order to use goreportcard. Agree?

@texadactyl
Copy link
Author

It would be helpful if there was a way for goreportcard to be verbose while walking the github site tree. I suggest that goreportcard display each directory as it traverses the tree.

@texadactyl
Copy link
Author

texadactyl commented Dec 31, 2023

What is "v2" under badger? I see branches release/v2.0 and release/v2.2007
under https://github.com/dgraph-io/badger.

It seems that the web version of goreportcard is failing because of its inability to use badger while the CLI version simply walks the tree rooted at the current directory and gets the job done.

Also, you might want to consider not being dependent on a particular version of badger if at all possible. Taking my own medicine, as it were: my badger app makes no mention in the source code of the badger version (I just get the latest stable version if badger is updated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant