Skip to content

runtime: goroutine leak detection by using the garbage collector #74622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
+534 −46
Open

runtime: goroutine leak detection by using the garbage collector #74622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cf94234
Proposal #74609: goroutine leak detection by using the garbage collec…
VladSaiocUber Jul 15, 2025
352dc0d
Corrected sema dequeue implementation.
VladSaiocUber Jul 16, 2025
f903068
Ordered wait reasons for easier checks.
VladSaiocUber Jul 16, 2025
f8a6d93
Optimized bitmask check in scanobject.
VladSaiocUber Jul 17, 2025
67a74ab
Renamed deadlockgc to golfgc and deadlocks to goroutine leaks to avoi…
VladSaiocUber Jul 17, 2025
d985e99
Fixed status text for leaked goroutines.
VladSaiocUber Jul 18, 2025
76ff6cf
Fixed bad goroutine status.
VladSaiocUber Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/internal/goexperiment/exp_golfgc_off.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions src/internal/goexperiment/exp_golfgc_on.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/internal/goexperiment/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,4 +129,7 @@ type Flags struct {

// GreenTeaGC enables the Green Tea GC implementation.
GreenTeaGC bool

// GolfGC enables the Deadlock GC implementation.
GolfGC bool
}
2 changes: 1 addition & 1 deletion src/runtime/export_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,7 @@ func (t *SemTable) Enqueue(addr *uint32) {
s.releasetime = 0
s.acquiretime = 0
s.ticket = 0
t.semTable.rootFor(addr).queue(addr, s, false)
t.semTable.rootFor(addr).queue(addr, s, false, false)
}

// Dequeue simulates dequeuing a waiter for a semaphore (or lock) at addr.
Expand Down
Loading