Skip to content

CodeReview

Josh Bleecher Snyder edited this page Jan 10, 2015 · 21 revisions

Be sure to familiarize yourself with the code review process from the official Contribution Guidelines first.

Reviewer Parlance

There are several terms code reviews may use that you should become familiar with.

  • LGTM — looks good to me
  • SGTM — sounds good to me
  • s/foo/bar/ — please replace foo with bar; this is sed syntax.
  • s/foo/bar/g — please replace foo with bar throughout your entire change

Email

Messages from a code review are typically sent to three places:

  • the reviewers, if any
  • the golang-codereviews group
  • the owner

Please do NOT reply code review via email, as the message will not be relayed to Gerrit. Always click on the link and post reply in Gerrit.

Code Review on Windows

The code review command git-codereview currently does not work on Windows. This is #9257.

Clone this wiki locally