Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: tables are awkwardly formatted #67368

Open
jjlin opened this issue May 14, 2024 · 3 comments · May be fixed by golang/website#288
Open

x/website: tables are awkwardly formatted #67368

jjlin opened this issue May 14, 2024 · 3 comments · May be fixed by golang/website#288
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Milestone
website/unplanned

Comments

@jjlin
Copy link

jjlin commented May 14, 2024

What is the URL of the page with the issue?

https://go.dev/ref/mod#environment-variables

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/124.0.0.0 Safari/537.36

Screenshot

image

What did you do?

Visit https://go.dev/ref/mod#environment-variables

What did you see happen?

The table of environment variables has no cell borders and the content is vertically centered. This makes it needlessly difficult to understand which variable corresponds to which description, and where one description ends and the next begins.

What did you expect to see?

If the table is going to have no borders, then I think the content should be top-aligned.

I'd expect that other tables in the Go documentation probably have this issue as well.
@jjlin jjlin added the pkgsite label May 14, 2024
@seankhliao seankhliao changed the title Tables in Go documentation are awkwardly formatted x/website: tables are awkwardly formatted May 15, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 15, 2024
@seankhliao seankhliao added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed Documentation pkgsite labels May 15, 2024
@hyangah
Copy link
Contributor

hyangah commented May 23, 2024

I agree this table will look better and more readable if it's top-aligned.
CSS adjustment for this table is welcome.

@0x1306e6d 0x1306e6d linked a pull request Jun 16, 2024 that will close this issue
Open
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/592955 mentions this issue: _content: add styles for mod table

@kevinpeno
Copy link

kevinpeno commented Oct 14, 2024 •
edited
Loading

Not sure where to throw it, but the following worked well for that page, imo. The padding isn't necessary, but I thought it helped readability a little bit. I didn't see .ModTable defined anywhere in styles.css, so there shouldn't be any conflicts.

.ModTable th, .ModTable td {
    vertical-align: baseline;
    text-align: left;
    padding: 1rem;
}

Screenshot 2024-10-13 200255
Screenshot 2024-10-13 200238
Screenshot 2024-10-13 200218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Projects
None yet
Milestone
website/unplanned
Development

Successfully merging a pull request may close this issue.

_content: add styles for mod table 0x1306e6d/website
5 participants
@jjlin @kevinpeno @hyangah @gopherbot @seankhliao