-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHC 8.10 checklist #385
Labels
Comments
RyanGlScott
added a commit
that referenced
this issue
Jan 25, 2020
This is in preparation for some changes that require 8.10 as the minimum GHC version. See #385. Some knock-on changes include: * Unsurprisingly, GHC 8.10 slightly changes the way `-ddump-splices` output is pretty-printed, so some test cases' expected output have been updated accordingly. * Now that we only build against GHC 8.10, we can get rid of some CPP only needed for older GHCs. * GHC 8.10 now warns about unqualified `Data.List` imports, so some minor tweaks are needed to avoid these warnings.
RyanGlScott
added a commit
that referenced
this issue
Jan 25, 2020
This is in preparation for some changes that require 8.10 as the minimum GHC version. See #385. Some knock-on changes include: * Unsurprisingly, GHC 8.10 slightly changes the way `-ddump-splices` output is pretty-printed, so some test cases' expected output have been updated accordingly. * Now that we only build against GHC 8.10, we can get rid of some CPP only needed for older GHCs. * GHC 8.10 now warns about unqualified `Data.List` imports, so some minor tweaks are needed to avoid these warnings.
RyanGlScott
added a commit
that referenced
this issue
Jan 25, 2020
This is in preparation for some changes that require 8.10 as the minimum GHC version. See #385. Some knock-on changes include: * Unsurprisingly, GHC 8.10 slightly changes the way `-ddump-splices` output is pretty-printed, so some test cases' expected output have been updated accordingly. * Now that we only build against GHC 8.10, we can get rid of some CPP only needed for older GHCs. * GHC 8.10 now warns about unqualified `Data.List` imports, so some minor tweaks are needed to avoid these warnings.
RyanGlScott
added a commit
that referenced
this issue
Jan 26, 2020
This is in preparation for some changes that require 8.10 as the minimum GHC version. See #385. Some knock-on changes include: * Unsurprisingly, GHC 8.10 slightly changes the way `-ddump-splices` output is pretty-printed, so some test cases' expected output have been updated accordingly. * Now that we only build against GHC 8.10, we can get rid of some CPP only needed for older GHCs. * GHC 8.10 now warns about unqualified `Data.List` imports, so some minor tweaks are needed to avoid these warnings.
Now that GHC 8.10.1 is out, I plan to release |
No objections from me, certainly! |
Fixed with the Hackage release of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue serves as a reminder to do certain things before we ship a new major release that supports GHC 8.10:
th-desugar
(see GHC 8.10 checklist th-desugar#114).singletons
doesn't fully supportTypeApplications
in theREADME
.This comment in
Data.Singletons.Promote.Defun
suggests some code cleanup that would be possible with VDQ:singletons/src/Data/Singletons/Promote/Defun.hs
Lines 405 to 412 in ea63077
Current,
Sigma
is defined to be:singletons/src/Data/Singletons/Sigma.hs
Line 34 in ea63077
Why not:
Currently, we need
ImpredicativeTypes
inData.Singletons.Sigma
due to this type synonym:singletons/src/Data/Singletons/Sigma.hs
Line 39 in ea63077
However, we could eliminate the use of
ImpredicativeTypes
altogether by just givingΣ
a standalone kind signature:singletons
against the deprecation of theCUSKs
extension by giving more declarations standalone kind signatures:ApplyTyCon
:SndSigma
:The text was updated successfully, but these errors were encountered: