Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hasura Metadata generation can cause unwanted diffs #219

Open
WonderPanda opened this issue Jan 16, 2021 · 2 comments
Open

Hasura Metadata generation can cause unwanted diffs #219

WonderPanda opened this issue Jan 16, 2021 · 2 comments
Labels
enhancement New feature or request stale

Comments

@WonderPanda
Copy link
Collaborator

When writing out metadata using js-yaml the ordering of properties is different compared to what is generated by Hasura.

In order to address this logic will be added to only write out metadata if an actual logical change has been detected in one of the managed objects instead of doing it proactively every time the module is booted up

@WonderPanda WonderPanda added the enhancement New feature or request label Jan 16, 2021
WonderPanda added a commit that referenced this issue Jan 16, 2021
align the output format of managed metadata to match what hasura produces

re #219
WonderPanda added a commit that referenced this issue Jan 16, 2021
align the output format of managed metadata to match what hasura produces

re #219
@WonderPanda
Copy link
Collaborator Author

It turns out that we can get 99.9% of the way there by just explicitly constructing the Javascript objects with the same key order as what is generated by Hasura,

The only difference now is in how multi line strings are managed. js-yaml uses the >- prefix. Its not clear yet whether its worth spending time trying to correct this

Copy link

github-actions bot commented Oct 3, 2024

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

1 participant