Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link directs to article header image instead of article itself #152

Open
Jacksaur opened this issue Nov 26, 2024 · 1 comment
Open

Link directs to article header image instead of article itself #152

Jacksaur opened this issue Nov 26, 2024 · 1 comment

Comments

@Jacksaur
Copy link

Jacksaur commented Nov 26, 2024

Describe the bug
Upon adding a bookmark for a PCGamer article, Grimoire substitutes out the link to the direct source for the header image of the article instead. Clicking the bookmark just takes me to this image every time, instead of the actual link I pasted. This has only happened with this specific article so far: I tried with other PCG articles and they linked through fine. No idea what this one is doing differently to trigger this behaviour.

To Reproduce

  1. Add Bookmark
  2. Paste this link https://www.pcgamer.com/games/strategy/i-tracked-down-the-guy-who-gave-a-negative-review-to-battlezone-98-redux-after-playing-for-over-8-000-hours-and-came-away-convinced-he-was-right/
  3. Link will immediately turn into a link for the header image instead. All other details will be correct, including the HTML breakdown of the originally provided link.
  4. Click bookmarked link after saving.
  5. Link will just lead to image.

Screenshots

Expected behavior
The original link I pasted is opened.

@gpoussel
Copy link
Contributor

gpoussel commented Dec 5, 2024

Digging into this issue, I have found the root cause: url-metadata package and its method of extracting schema.org micro-formatting attributes.
Even if the URL attribute of a <meta itemprop="url" ...> tag is scoped to an ImageObject, it will be assigned to the entire page. I have opened an issue on their repo: laurengarcia/url-metadata#90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants