Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile is not compatible with tf 2.16.1 #72

Open
mwprado opened this issue Aug 16, 2024 · 6 comments · May be fixed by #74
Open

Makefile is not compatible with tf 2.16.1 #72

mwprado opened this issue Aug 16, 2024 · 6 comments · May be fixed by #74

Comments

@mwprado
Copy link

mwprado commented Aug 16, 2024

If you try compile using make, shows there isn't common.c file. In Tf 2.16.1 there is only common.cc .

@mwprado mwprado closed this as completed Aug 16, 2024
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

@mwprado mwprado reopened this Aug 16, 2024
@FeeJai
Copy link

FeeJai commented Sep 5, 2024

got the same issue here.

@mwprado
Copy link
Author

mwprado commented Sep 18, 2024

got the same issue here.

I fixed makefile:

new_makefile.patch.txt

feranick added a commit to feranick/libedgetpu that referenced this issue Sep 18, 2024
feranick added a commit to feranick/libedgetpu that referenced this issue Sep 18, 2024
Still refers to ancient versions of TF.

In reference to:
google-coral#66
google-coral#72
@mwprado
Copy link
Author

mwprado commented Sep 18, 2024

@feranick common_internal.cc needs be relocated to LIBEDGETPU_CCSRCS variable as my patch set it.

@jagiella
Copy link

jagiella commented Sep 30, 2024

@feranick without the patch provided by @mwprado it won't compile, even with the newest commit of the main branch.

Additionally, it is important to mention, that the documentation is misleading (not to say wrong) in respect to the build dependencies: On ubuntu / debian systems the provided package for libflatbuffers-dev uses a different scheme for version numbers. The current versions are v2.0.8 (debian bookworm / ubuntu 24.04), but tensorflow requests v23.x.y. So builds will never work, eventhough the documention suggests, it would.

It would be great to change the documentation and add instructions to build and install the matching flatbuffer version which tensorflow requires.

Please add to makefile_build documentation

For example for tensorflow 2.16.1 you require to build and install libflatbuffers 23.5.26:

git clone https://github.com/google/flatbuffers.git
cd flatbuffers/
git checkout v23.5.26
mkdir build && cd build
cmake .. -DFLATBUFFERS_BUILD_SHAREDLIB=ON -DFLATBUFFERS_BUILD_TESTS=OFF -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/usr
make -j$(nproc)
sudo make install

Please add to main documentation

And in order to make debian packages using the Makefile-only approach you need to build both versions of the library first (std, max) before the packaging routine can successfully been run:

TFROOT=<Directory of Tensorflow>/ make -f makefile_build/Makefile -j$(nproc)
debuild -us -uc -tc -b -a amd64 -d

@feranick
Copy link
Contributor

@jagiella I am not sure why you are tagging me on this. I am not a Google developer and have no access to the main repo. Feel free to create an actual patch, make a PR against the main repo and hope that it gets merged.

I maintain a separate fork that is updated:
https://github.com/feranick/libedgetpu/

with a PR to the main repo:
#70

@jagiella jagiella linked a pull request Oct 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants