Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seek in AAC #1079

Closed
ghost opened this issue Dec 21, 2015 · 11 comments
Closed

Seek in AAC #1079

ghost opened this issue Dec 21, 2015 · 11 comments
Labels

Comments

@ghost
Copy link

ghost commented Dec 21, 2015

According to #227 it is not supported to seek in an AAC stream. Is it somehow possible to implement this feature?

I need to seek within a AAC file that is shorter than 10 seconds and is stored on the clients device.

Any pointers would be appreciated.

@andrewlewis
Copy link
Collaborator

Is it possible to put the media in a container where we support seeking, like MP4 or Matroska?

As noted in #227, to seek in a .aac file (using AdtsExtractor) it seems that it is necessary to build an index having read the whole file, which is generally not efficient.

@ghost
Copy link
Author

ghost commented Dec 26, 2015

Thanks for the answer, I will put the stream file into an mp4 container

@ojw28 ojw28 closed this as completed Dec 27, 2015
@pottabathini
Copy link

@andrewlewis
I am sorry to comment in a closed thread, but I think this is good place to add my comment to know more information/ example form you.

I red above comment there you written

Is it possible to put the media in a container where we support seeking, like MP4 or Matroska?

Can you give example on this, I am playing MP4 video so I hope there is a chance of seek from your answer. If you give sample code or example that would be great.

@andrewlewis
Copy link
Collaborator

@pottabathini Is there a specific problem you are seeing? Seeking in unfragmented MP4 and fragmented MP4 files with indices should just work.

@pottabathini
Copy link

@andrewlewis When I seek forward it is just working fine but when I seek backward, buffered content also going and again it is buffering from the seek position

I need a behaviour my buffered video should stay when I seek backward it should not again load, is there any specific settings we need to do?

Please guide me to overcome this.
Thank you

@andrewlewis
Copy link
Collaborator

I'm afraid this is working as intended for the current design. See #896 and #978.

@pottabathini
Copy link

@andrewlewis Sorry andrew I thought we need to change some settings to work this but as per your answer this is a code level change.

I am using Xamarin bindings for your ExoPlayer which is written by @martijn00 https://github.com/martijn00/ExoPlayerXamarin

Unfortunately he is still in .4 version only. I will check with him to update xamarin andorid bindings.

Thank you

@andrewlewis
Copy link
Collaborator

We do not currently support retaining data before the current playback position, so you will always see buffering when seeking backwards, even in the latest version. Sorry if I wasn't clear in my previous reply.

As per the linked issues, we might change this behavior so that we only discard data if it's possible to buffer more future media (for example, if the entire stream fits in the buffer) but this is not a priority at the moment.

@andrewlewis
Copy link
Collaborator

Correction: we might change this behavior so that we only discard data if it's impossible to buffer more future media (for example, if the entire stream fits in the buffer)

@pottabathini
Copy link

yes, sounds good but as per your response you guys are not taking this has priority to implement as of now :-(

Unfortunately for my project it is very high priority where user see the videos of time less than 3 to 5 minutes. if he is in mobile data when he seek to and fro few times it will keep on load and it will consume more mobile data

@andrewlewis
Copy link
Collaborator

Please ignore the previous correction! I meant to write that: we might change this behavior so that we only discard data if it's possible to buffer more future media. If the entire stream fits in the buffer, there is no more media to buffer, so the played data wouldn't be discarded.

Sorry the current functionality is suboptimal for your use case.

@google google locked and limited conversation to collaborators Jun 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants