From c5b08fdf481e5d9242a6d1c45bc4d963d1429873 Mon Sep 17 00:00:00 2001 From: kaczmarczyck <43844792+kaczmarczyck@users.noreply.github.com> Date: Tue, 1 Oct 2024 16:33:56 +0200 Subject: [PATCH] Fixes incorrect error code for vendor U2F (#707) --- libraries/opensk/src/ctap/ctap1.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libraries/opensk/src/ctap/ctap1.rs b/libraries/opensk/src/ctap/ctap1.rs index f279f1e1..783e0a75 100644 --- a/libraries/opensk/src/ctap/ctap1.rs +++ b/libraries/opensk/src/ctap/ctap1.rs @@ -233,8 +233,7 @@ impl Ctap1Command { // U2F raw message format specification (version 20170411) section 6.3 U2fCommand::Version => Ok(Vec::::from(super::U2F_VERSION_STRING)), - // TODO: should we return an error instead such as SW_INS_NOT_SUPPORTED? - U2fCommand::VendorSpecific { .. } => Err(Ctap1StatusCode::SW_SUCCESS), + U2fCommand::VendorSpecific { .. } => Err(Ctap1StatusCode::SW_INS_INVALID), } }