Skip to content
This repository was archived by the owner on Aug 10, 2022. It is now read-only.
This repository was archived by the owner on Aug 10, 2022. It is now read-only.

Add event.waitUntil to service worker primers code sample #6199

Open
@philipwalton

Description

@philipwalton

Page Affected: https://developers.google.com/web/fundamentals/primers/service-workers/#cache_and_return_requests

What needs to be done?

Discovered in a Twitter conversation, this code example needs to be calling event.waitUntil() so the SW doesn't shut down before putting the response in the cache:
https://twitter.com/wesbos/status/1001519885661425665

  • Appropriate type-something label has been added.
  • Appropriate section-something label has been added.

/cc: @jeffposnick

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions