update unit test code for test_connection

Author: anencore94

.github/workflows/python-unit-tests.yml

@@ -2,9 +2,9 @@ name: Python Unit Tests
 
 on:
   push:
-    branches: [ main ]
+    branches: [main]
   pull_request:
-    branches: [ main ]
+    branches: [main]
 
 jobs:
   test:
@@ -14,28 +14,26 @@ jobs:
         python-version: ["3.9", "3.10", "3.11"]
 
     steps:
-    - name: Checkout code
-      uses: actions/checkout@v4
+      - name: Checkout code
+        uses: actions/checkout@v4
 
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v5
-      with:
-        python-version: ${{ matrix.python-version }}
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v5
+        with:
+          python-version: ${{ matrix.python-version }}
 
-    - name: Install uv
-      run: curl -LsSf https://astral.sh/uv/install.sh | sh
+      - name: Install uv
+        run: curl -LsSf https://astral.sh/uv/install.sh | sh
 
-    - name: Install dependencies
-      run: |
-        uv venv .venv
-        source .venv/bin/activate
-        uv sync --extra test --extra eval
+      - name: Install dependencies
+        run: |
+          uv venv .venv
+          source .venv/bin/activate
+          uv sync --extra test --extra eval
 
-    - name: Run unit tests with pytest
-      run: |
-        source .venv/bin/activate
-        pytest tests/unittests \
-          --ignore=tests/unittests/artifacts/test_artifact_service.py \
-          --ignore=tests/unittests/tools/application_integration_tool/clients/test_connections_client.py \
-          --ignore=tests/unittests/tools/google_api_tool/test_googleapi_to_openapi_converter.py        
-          
+      - name: Run unit tests with pytest
+        run: |
+          source .venv/bin/activate
+          pytest tests/unittests \
+            --ignore=tests/unittests/artifacts/test_artifact_service.py \
+            --ignore=tests/unittests/tools/google_api_tool/test_googleapi_to_openapi_converter.py

tests/unittests/tools/application_integration_tool/clients/test_connections_client.py

@@ -169,6 +169,7 @@ def test_get_connection_details_success_with_host(
     mock_response = mock.MagicMock()
     mock_response.status_code = 200
     mock_response.json.return_value = {
+        "name": "test-connection",
         "serviceDirectory": "test_service",
         "host": "test.host",
         "tlsServiceDirectory": "tls_test_service",
@@ -180,6 +181,7 @@ def test_get_connection_details_success_with_host(
     ):
       details = client.get_connection_details()
       assert details == {
+          "name": "test-connection",
           "serviceName": "tls_test_service",
           "host": "test.host",
           "authOverrideEnabled": True,
@@ -193,6 +195,7 @@ def test_get_connection_details_success_without_host(
     mock_response = mock.MagicMock()
     mock_response.status_code = 200
     mock_response.json.return_value = {
+        "name": "test-connection",
         "serviceDirectory": "test_service",
         "authOverrideEnabled": False,
     }
@@ -202,11 +205,35 @@ def test_get_connection_details_success_without_host(
     ):
       details = client.get_connection_details()
       assert details == {
+          "name": "test-connection",
           "serviceName": "test_service",
           "host": "",
           "authOverrideEnabled": False,
       }
+    
+  def test_get_connection_details_without_name(
+      self, project, location, connection_name, mock_credentials
+  ):
+    credentials = {"email": "[email protected]"}
+    client = ConnectionsClient(project, location, connection_name, credentials)
+    mock_response = mock.MagicMock()
+    mock_response.status_code = 200
+    mock_response.json.return_value = {
+        "serviceDirectory": "test_service",
+        "authOverrideEnabled": False,
+    }
 
+    with mock.patch.object(
+        client, "_execute_api_call", return_value=mock_response
+    ):
+      details = client.get_connection_details()
+      assert details == {
+          "name": "",
+          "serviceName": "test_service",
+          "host": "",
+          "authOverrideEnabled": False,
+      }
+      
   def test_get_connection_details_error(
       self, project, location, connection_name
   ):
@@ -419,21 +446,21 @@ def test_get_operation_static(self):
   def test_create_operation(self):
     operation = ConnectionsClient.create_operation("Entity1", "test_tool")
     assert "post" in operation
-    assert operation["post"]["summary"] == "Create Entity1"
+    assert operation["post"]["summary"] == "Creates a new Entity1"
     assert "operationId" in operation["post"]
     assert operation["post"]["operationId"] == "test_tool_create_Entity1"
 
   def test_update_operation(self):
     operation = ConnectionsClient.update_operation("Entity1", "test_tool")
     assert "post" in operation
-    assert operation["post"]["summary"] == "Update Entity1"
+    assert operation["post"]["summary"] == "Updates the Entity1"
     assert "operationId" in operation["post"]
     assert operation["post"]["operationId"] == "test_tool_update_Entity1"
 
   def test_delete_operation(self):
     operation = ConnectionsClient.delete_operation("Entity1", "test_tool")
     assert "post" in operation
-    assert operation["post"]["summary"] == "Delete Entity1"
+    assert operation["post"]["summary"] == "Delete the Entity1"
     assert operation["post"]["operationId"] == "test_tool_delete_Entity1"
 
   def test_create_operation_request(self):