diff --git a/src/app/components/chat/chat.component.html b/src/app/components/chat/chat.component.html index f1f8704b..c7d41980 100644 --- a/src/app/components/chat/chat.component.html +++ b/src/app/components/chat/chat.component.html @@ -62,7 +62,6 @@ [eventData]="eventData" [currentSessionState]="currentSessionState" [artifacts]="artifacts" - [shouldShowEvalTab]="shouldShowEvalTab()" [selectedEvent]="selectedEvent" [selectedEventIndex]="selectedEventIndex" [renderedEventGraph]="renderedEventGraph" @@ -74,7 +73,6 @@ (eventSelected)="selectEvent($event)" (sessionSelected)="updateWithSelectedSession($event)" (sessionReloaded)="updateSessionState($event)" - (evalTabVisibilityChange)="handleShouldShowEvalTab($event)" (evalCaseSelected)="updateWithSelectedEvalCase($event)" (evalSetIdSelected)="updateSelectedEvalSetId($event)" (returnToSession)="handleReturnToSession($event)" diff --git a/src/app/components/chat/chat.component.ts b/src/app/components/chat/chat.component.ts index b6f86f2f..1f61021e 100644 --- a/src/app/components/chat/chat.component.ts +++ b/src/app/components/chat/chat.component.ts @@ -151,7 +151,6 @@ export class ChatComponent implements OnInit, AfterViewInit, OnDestroy { private scrollContainer = viewChild.required('autoScroll'); bottomPanelRef = viewChild.required('bottomPanel'); private _snackBar = inject(MatSnackBar); - shouldShowEvalTab = signal(true); enableSseIndicator = signal(false); isChatMode = signal(true); isEvalCaseEditing = signal(false); @@ -1094,10 +1093,6 @@ export class ChatComponent implements OnInit, AfterViewInit, OnDestroy { } } - protected handleShouldShowEvalTab(shouldShow: boolean) { - this.shouldShowEvalTab.set(shouldShow); - } - protected handleReturnToSession(event: boolean) { this.sessionTab()?.getSession(this.sessionId); this.evalTab()?.resetEvalCase(); diff --git a/src/app/components/side-panel/side-panel.component.html b/src/app/components/side-panel/side-panel.component.html index 4e582c8a..7e2b327a 100644 --- a/src/app/components/side-panel/side-panel.component.html +++ b/src/app/components/side-panel/side-panel.component.html @@ -60,7 +60,6 @@ > - @if (shouldShowEvalTab) { {{ i18n.evalTabLabel }} @@ -69,7 +68,6 @@ [appName]="appName" [userId]="userId" [sessionId]="sessionId" - (shouldShowTab)="evalTabVisibilityChange.emit($event)" (sessionSelected)="sessionSelected.emit($event)" (evalCaseSelected)="evalCaseSelected.emit($event)" (evalSetIdSelected)="evalSetIdSelected.emit($event)" @@ -77,7 +75,6 @@ (evalNotInstalledMsg)="evalNotInstalled.emit($event)" > - } } @if (this.selectedEvent && showSidePanel) { diff --git a/src/app/components/side-panel/side-panel.component.spec.ts b/src/app/components/side-panel/side-panel.component.spec.ts index a990a5a7..5de1a4ec 100644 --- a/src/app/components/side-panel/side-panel.component.spec.ts +++ b/src/app/components/side-panel/side-panel.component.spec.ts @@ -320,37 +320,11 @@ describe('SidePanelComponent', () => { }); describe('Eval tab', () => { - beforeEach(() => { - component.shouldShowEvalTab = true; - fixture.detectChanges(); - }); - - describe('when shouldShowEvalTab is true', () => { - beforeEach(async () => { - await switchTab(EVAL_TAB_INDEX); - }); - it('is visible', () => { - expect(fixture.debugElement.query(EVAL_TAB_SELECTOR)).toBeTruthy(); - }); - }); - describe('Interactions', () => { beforeEach(async () => { await switchTab(EVAL_TAB_INDEX); }); - describe('when app-eval-tab emits shouldShowTab', () => { - beforeEach(() => { - spyOn(component.evalTabVisibilityChange, 'emit'); - const evalTab = fixture.debugElement.query(EVAL_TAB_SELECTOR); - evalTab.triggerEventHandler('shouldShowTab', false); - }); - it('emits evalTabVisibilityChange', () => { - expect(component.evalTabVisibilityChange.emit) - .toHaveBeenCalledWith(false); - }); - }); - describe('when app-eval-tab emits evalCaseSelected', () => { beforeEach(() => { spyOn(component.evalCaseSelected, 'emit'); diff --git a/src/app/components/side-panel/side-panel.component.ts b/src/app/components/side-panel/side-panel.component.ts index a7467aea..6d520d3f 100644 --- a/src/app/components/side-panel/side-panel.component.ts +++ b/src/app/components/side-panel/side-panel.component.ts @@ -71,7 +71,6 @@ export class SidePanelComponent { @Input() eventData = new Map(); @Input() currentSessionState: any; @Input() artifacts: any[] = []; - @Input() shouldShowEvalTab = false; @Input() selectedEvent: any|undefined; @Input() selectedEventIndex: number|undefined; @Input() renderedEventGraph: SafeHtml|undefined; @@ -85,7 +84,6 @@ export class SidePanelComponent { @Output() readonly eventSelected = new EventEmitter(); @Output() readonly sessionSelected = new EventEmitter(); @Output() readonly sessionReloaded = new EventEmitter(); - @Output() readonly evalTabVisibilityChange = new EventEmitter(); @Output() readonly evalCaseSelected = new EventEmitter(); @Output() readonly evalSetIdSelected = new EventEmitter(); @Output() readonly returnToSession = new EventEmitter();