Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoValue 1.7.1 Breaks Incremental Annotation Processing #844

Closed
ZacSweers opened this issue May 5, 2020 · 6 comments · Fixed by #845
Closed

AutoValue 1.7.1 Breaks Incremental Annotation Processing #844

ZacSweers opened this issue May 5, 2020 · 6 comments · Fixed by #845
Assignees
@eamonnmcmanus

Comments

@ZacSweers
Copy link
Contributor

Since updating to 1.7.1, AutoValue no longer appears to report its correct incremental annotation processing type

> Task :calendar:kaptReleaseKotlin
[WARN] Incremental annotation processing requested, but support is disabled because the following processors are not incremental: com.google.auto.value.processor.AutoValueProcessor (DYNAMIC).

Note that we see this for projects with extensions and projects with no extensions.
@eamonnmcmanus eamonnmcmanus self-assigned this May 6, 2020
@eamonnmcmanus
Copy link
Member

Thanks for bringing this to our attention! Unfortunately we don't use Gradle internally, and AutoValue doesn't have proper test coverage for this area, so we missed this. I'm pretty sure the problem is that this new extension needs to have code like this. If you're able to test that by building a modified snapshot that would certainly be helpful. Meanwhile I'll look into how we could avoid problems like this in the future.

@tbroyer
Copy link
Contributor

tbroyer commented May 6, 2020

Related: tbroyer/gradle-incap-helper#2
Unfortunately, I haven't progressed much on this issue since last fall…

@eamonnmcmanus
Copy link
Member

We can at least test that AutoValueProcessor when configured with its built-in extensions still reports itself as ISOLATING. That test would have detected the problem here. I have a fix in the pipeline.

eamonnmcmanus added a commit that referenced this issue May 8, 2020
@eamonnmcmanus
Have SerializableAutoValueExtension declare that it is "isolating".
44ca4dd 
Since it is a built-in extension, and since AutoValue itself only describes
itself as isolating if all extensions are, this omission meant that the
presence of AutoValue disabled incremental builds in Gradle.

Add a test to ensure that we don't forget this with future extensions.

Fixes #844.

RELNOTES=AutoValue is once again "isolating" for Gradle incremental compilation.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=310610697
@eamonnmcmanus eamonnmcmanus mentioned this issue May 8, 2020
Merged
eamonnmcmanus added a commit that referenced this issue May 8, 2020
@eamonnmcmanus
Have SerializableAutoValueExtension declare that it is "isolating".
8e7515a 
Since it is a built-in extension, and since AutoValue itself only describes
itself as isolating if all extensions are, this omission meant that the
presence of AutoValue disabled incremental builds in Gradle.

Add a test to ensure that we don't forget this with future extensions.

Fixes #844.

RELNOTES=AutoValue is once again "isolating" for Gradle incremental compilation.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=310610697
@eamonnmcmanus
Copy link
Member

I've just released 1.7.2 which should fix this problem. Let me know if it doesn't.

@ZacSweers
Copy link
Contributor Author

ZacSweers commented May 13, 2020 via email

@ZacSweers
Copy link
Contributor Author

Sorry was late on this - did try and was resolved for us 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eamonnmcmanus eamonnmcmanus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Have SerializableAutoValueExtension declare that it is "isolating". google/auto
3 participants
@tbroyer @ZacSweers @eamonnmcmanus