Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert ConvertResponse to Protobuf #1944

Open
timothyfroehlich opened this issue Dec 26, 2024 · 0 comments
Open

Convert ConvertResponse to Protobuf #1944

timothyfroehlich opened this issue Dec 26, 2024 · 0 comments

Comments

@timothyfroehlich
Copy link
Member

This type is used to send the converted Figma doc from the Rust code to the Kotlin code, across the JNI boundary. It is the last remaining use for serde reflection and should be converted to Protobuf so that we can remove the serde reflection dependency.
timothyfroehlich added a commit that referenced this issue Dec 26, 2024
@timothyfroehlich
Remove almost all types from Serdegen reflection
5583809 
We are able to successfully compile without almost anything from Serdegen reflection. The one exception is the `ConvertResponse` type, part of the JNI boundary, which just holds the already-encoded doc. It can be cleaned up in another task. (#1944)
@timothyfroehlich timothyfroehlich mentioned this issue Dec 26, 2024
Closed
timothyfroehlich added a commit that referenced this issue Dec 26, 2024
@timothyfroehlich
Remove almost all types from Serdegen reflection
edd58c3 
We are able to successfully compile without almost anything from Serdegen reflection. The one exception is the `ConvertResponse` type, part of the JNI boundary, which just holds the already-encoded doc. It can be cleaned up in another task. (#1944)
timothyfroehlich added a commit that referenced this issue Dec 26, 2024
@timothyfroehlich
Remove almost all types from Serdegen reflection
59f773b 
We are able to successfully compile without almost anything from Serdegen reflection. The one exception is the `ConvertResponse` type, part of the JNI boundary, which just holds the already-encoded doc. It can be cleaned up in another task. (#1944)
timothyfroehlich added a commit that referenced this issue Dec 26, 2024
@timothyfroehlich
Remove almost all types from Serdegen reflection
1d39f2f 
We are able to successfully compile without almost anything from Serdegen reflection. The one exception is the ConvertResponse type, part of the JNI boundary, which just holds the already-encoded doc. It can be cleaned up in another task. (#1944)
timothyfroehlich added a commit that referenced this issue Dec 26, 2024
@timothyfroehlich
Remove almost all types from Serdegen reflection
2d0ffba 
We are able to successfully compile without almost anything from Serdegen reflection. The one exception is the ConvertResponse type, part of the JNI boundary, which just holds the already-encoded doc. It can be cleaned up in another task. (#1944)
@timothyfroehlich timothyfroehlich mentioned this issue Dec 26, 2024
Merged
timothyfroehlich added a commit that referenced this issue Dec 26, 2024
@timothyfroehlich
Remove almost all types from Serdegen reflection (#1951)
deaee2f 
We are able to successfully compile without almost anything from
Serdegen reflection. The one exception is the ConvertResponse type, part
of the JNI boundary, which just holds the already-encoded doc. It can be
cleaned up in another task. (#1944)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
DesignCompose
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timothyfroehlich