Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation plugin unregister/re-register copy/cut/paste shortcuts #2424

Open
1 task done
changminbark opened this issue Jul 25, 2024 · 1 comment
Open
1 task done
Labels
type: feature request New feature or request

Comments

@changminbark
Copy link
Contributor

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

Keyboard Navigation Plugin

Problem

Currently, when combining the keyboard navigation plugin with the multiselect plugin, the copy/cut/paste shortcuts overlap. That is why the multiselect mode unregisters its copy/cut/paste shortcuts when the keyboard navigation mode is on and re-registers it when the keyboard navigation mode is turned off. However, this leads to an issue where the user cannot use the original copy/cut/paste shortcuts with the cursor while the keyboard navigation mode is on.

Request

One of the solutions to this would be to introduce a way to unregister/re-register the keyboard navigation plugin's copy/cut/paste shortcuts. That way, we can unregister/re-register the original Blockly core's copy/cut/paste shortcuts without running into a collision error.

More information regarding the issue from the multiselect side: mit-cml/workspace-multiselect#50 (comment)

image

Alternatives considered

The alternative solution to this would be to allow the original Blockly core's copy/cut/paste shortcuts to allow for collisions. However, this solution seems less elegant.

Additional context

No response

@BeksOmega
Copy link
Contributor

Heya @changminbark Thank you for reporting =) This is something we'll keep in mind as we test and refactor keyboard navigation! But I wouldn't consider compatibility with keyboard nav a blocker for your multiselect work. Keyboard nav is still a beta plugin, that we don't think is well suited to users yet.

@BeksOmega BeksOmega removed the triage label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants