Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop loading JS generator in the main blockly bundle #7625

Closed
1 task done
BeksOmega opened this issue Oct 31, 2023 · 4 comments · Fixed by #7822
Closed
1 task done

Stop loading JS generator in the main blockly bundle #7625

BeksOmega opened this issue Oct 31, 2023 · 4 comments · Fixed by #7822
Assignees
@cpcallen
Labels
issue: bug Describes why the code or behaviour is wrong
Milestone
Upcoming

Comments

@BeksOmega
Copy link
Collaborator

BeksOmega commented Oct 31, 2023 •
edited
Loading

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

When you access Blockly via import * as Blockly from 'blockly'; It loads the JS generator, but it isn't made accessible to external developers in any way. We should stop loading the JS generator.
@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels Oct 31, 2023
@maribethb maribethb added this to the Upcoming milestone Nov 1, 2023
@maribethb maribethb removed the issue: triage Issues awaiting triage by a Blockly team member label Nov 1, 2023
@cpcallen
Copy link
Contributor

This was fixed on 2023-07-07 by cl/546301258.

@BeksOmega BeksOmega reopened this Nov 17, 2023
@BeksOmega
Copy link
Collaborator Author

@cpcallen This is not a docs issue. This issue covers the fact that the browser and node packages unnecessarily import the javascript generator, but don't make it available.

@cpcallen
Copy link
Contributor

@cpcallen This is not a docs issue.

Quite correct. I was trying to close #6656, but apparently went to the wrong tab…

@cpcallen
Copy link
Contributor

This was fixed by #7822.

@cpcallen cpcallen linked a pull request May 10, 2024 that will close this issue
feat(build)!: Introduce exports section in package.json #7822
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpcallen cpcallen

Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
Upcoming
Development

Successfully merging a pull request may close this issue.

feat(build)!: Introduce exports section in package.json cpcallen/blockly
3 participants
@cpcallen @maribethb @BeksOmega