Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish "real" ESM modules usable by browser #8170

Closed
1 task done
jogibear9988 opened this issue May 22, 2024 · 3 comments
Closed
1 task done

Publish "real" ESM modules usable by browser #8170

jogibear9988 opened this issue May 22, 2024 · 3 comments
Assignees
Labels
issue: bug Describes why the code or behaviour is wrong

Comments

@jogibear9988
Copy link

Check for duplicates

  • I have searched for similar issues before opening a new one.

Description

With issue #7449 you seem to provide ESM modules.
But this are not real ESM modules wich are usable by the browser. They could only be used if you use a bundler

Reproduction steps

  1. Try the code from https://github.com/jogibear9988/blocklyEsmTest

Stack trace

Uncaught SyntaxError: The requested module './index.js' does not provide an export named 'default' (at index.mjs:1:8)

Screenshots

image

Browsers

Chrome desktop, Safari desktop, Firefox desktop, Android mobile, iOS mobile

@jogibear9988 jogibear9988 added issue: bug Describes why the code or behaviour is wrong issue: triage Issues awaiting triage by a Blockly team member labels May 22, 2024
@cpcallen
Copy link
Contributor

You are quite correct, and issue #7449 had been left open for exactly the reason you note. I will update that issue and then close this one.

@jogibear9988
Copy link
Author

@cpcallen you need to reopen it, it has been closed.

Maybe you could add the sample: https://github.com/jogibear9988/blocklyEsmTest

@cpcallen
Copy link
Contributor

you need to reopen it, it has been closed.

Done.

Maybe you could add the sample: https://github.com/jogibear9988/blocklyEsmTest

Also done. Thanks for the great import map example!

@cpcallen cpcallen self-assigned this May 22, 2024
@cpcallen cpcallen removed the issue: triage Issues awaiting triage by a Blockly team member label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

No branches or pull requests

2 participants