Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the blocklyNonSelectable CSS class and include non-selectability in existing classes instead #8328

Closed
BeksOmega opened this issue Jul 11, 2024 · 6 comments
Closed

Remove the blocklyNonSelectable CSS class and include non-selectability in existing classes instead #8328

BeksOmega opened this issue Jul 11, 2024 · 6 comments
Assignees
@dakshkanaujia
Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

The blocklyNonSelectable class just disables user selection. Instead of having a CSS class that is used to apply one CSS rule, we should include the rule in a more relevant class.
@BeksOmega BeksOmega added issue: bug Describes why the code or behaviour is wrong help wanted External contributions actively solicited labels Jul 11, 2024
@BeksOmega BeksOmega added this to the v12 milestone Jul 11, 2024
@dakshkanaujia
Copy link

Hey! @BeksOmega, please assign me this issue, I am working on it!

@BeksOmega
Copy link
Collaborator Author

Hiya @dakshkanaujia Go for it! Let me know if you have any questions =)

@dakshkanaujia
Copy link

Hey @BeksOmega, I can see the issue. The blocklyNonSelectable class is redundant. I can implement the functionality directly in the existing class. Am I on the right track?

@BeksOmega
Copy link
Collaborator Author

Yes! You want to move user-select: none into other CSS classes that are also defined on the DOM element.

@dakshkanaujia dakshkanaujia mentioned this issue Jul 17, 2024
Closed
1 task
@dakshkanaujia
Copy link

Hey @BeksOmega , can you help me with how can I proceed from here , to get this PR merged. I am facing issue in signing the CLA thing.

dakshkanaujia added a commit to dakshkanaujia/blockly that referenced this issue Jul 23, 2024
@dakshkanaujia
fix!: Removed redundant blocklyNonSelectable class and integrated non…
4096ffc 
…-selectability into existing classes google#8328
dakshkanaujia added a commit to dakshkanaujia/blockly that referenced this issue Jul 23, 2024
@dakshkanaujia
fix: Removed redundant blocklyNonSelectable class and integrated non-…
1b4cf27 
…selectability into existing classes google#8328
dakshkanaujia added a commit to dakshkanaujia/blockly that referenced this issue Jul 23, 2024
@dakshkanaujia
fix: remove redundant blocklyNonSelectable class and integrate non-se…
d30e14d 
…lectability into existing classes google#8328
dakshkanaujia added a commit to dakshkanaujia/blockly that referenced this issue Jul 25, 2024
@dakshkanaujia
fix: remove redundant blocklyNonSelectable class and integrate non-se…
555327a 
…lectability into existing classes google#8328
dakshkanaujia added a commit to dakshkanaujia/blockly that referenced this issue Jul 26, 2024
@dakshkanaujia
fix: remove redundant blocklyNonSelectable class and integrate non-se…
48cf671 
…lectability into existing classes google#8328
dakshkanaujia added a commit to dakshkanaujia/blockly that referenced this issue Jul 27, 2024
@dakshkanaujia
fix: remove redundant blocklyNonSelectable class and integrate non-se…
7355f17 
…lectability into existing classes google#8328
dakshkanaujia added a commit to dakshkanaujia/blockly that referenced this issue Jul 27, 2024
@dakshkanaujia
fix: remove redundant blocklyNonSelectable class and integrate non-se…
b3b6b83 
…lectability into existing classes google#8328
dakshkanaujia added a commit to dakshkanaujia/blockly that referenced this issue Jul 27, 2024
@dakshkanaujia
fix: remove redundant blocklyNonSelectable class and integrate non-se…
bedb25e 
…lectability into existing classes google#8328
@dakshkanaujia dakshkanaujia mentioned this issue Jul 27, 2024
Merged
1 task
dakshkanaujia added a commit to dakshkanaujia/blockly that referenced this issue Jul 27, 2024
@dakshkanaujia
fix: remove redundant blocklyNonSelectable class and integrate non-se…
2c25da8 
…lectability into existing classes google#8328
dakshkanaujia added a commit to dakshkanaujia/blockly that referenced this issue Jul 30, 2024
@dakshkanaujia
fix: remove redundant blocklyNonSelectable class and integrate non-se…
5877ead 
…lectability into existing classes google#8328
BeksOmega pushed a commit that referenced this issue Jul 30, 2024
@dakshkanaujia
fix!: Redundant blockly non selectable #8328 (#8433)
dc1f276 
* Remove redundant blocklyNonSelectable class and integrate non-selectability into existing classes

* Removed .gitpod file

* fix: remove redundant blocklyNonSelectable class and integrate non-selectability into existing classes #8328

* fix: remove redundant blocklyNonSelectable class and integrate non-selectability into existing classes #8328

* fix: remove redundant blocklyNonSelectable class and integrate non-selectability into existing classes #8328

* fix: remove redundant blocklyNonSelectable class and integrate non-selectability into existing classes #8328

* fix: remove redundant blocklyNonSelectable class and integrate non-selectability into existing classes #8328

* fix: remove redundant blocklyNonSelectable class and integrate non-selectability into existing classes
@BeksOmega
Copy link
Collaborator Author

Closed by #8433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakshkanaujia dakshkanaujia

Labels
help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
v12
2 participants
@BeksOmega @dakshkanaujia