Add generic tworker. #4418
Merged
Add generic tworker. #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tworker will only run preprocess and postprocess. It can do this regardless of the platform of the task. b/380104573
vitorguidi
reviewed
Nov 21, 2024
| # TODO(b/378684001): This code is very ugly, get rid of it when no more | ||
| # fuzz tasks are executed on the bots themselves (i.e. when the rearch | ||
| # is complete). | ||
| self.is_from_queue = is_from_queue |
There was a problem hiding this comment.
Does this mean that, once this gets deployed, everything is coming from batch?
There was a problem hiding this comment.
No.
It means that I don't need the hacky is_from_queue method to schedule fuzz tasks on batch anymore.
Because instead we are pushing to the preprocess queue.
vitorguidi
reviewed
Nov 21, 2024
|
|
||
|
|
||
| def is_tworker(): | ||
| return get_value('TWORKER', False) |
There was a problem hiding this comment.
Should this be True? This is a bit confusing, by reading environment.py, I do know what to expect from ast.eval when it gets '1' as input
There was a problem hiding this comment.
No. THis is the default value, which I want to be False if the env var isn't defined.
There was a problem hiding this comment.
I thought i replied to this earlier, but no, I want the default to be False.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tworker will only run preprocess and postprocess.
By generic, I mean it can do this regardless of the platform of the task.
Also, get rid of some kludges used to test utasks in oss-fuzz.
b/380104573