Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to use same pattern as UrlPattern #162

Open
jonasfj opened this issue Oct 25, 2021 · 3 comments
Open

Migrate to use same pattern as UrlPattern #162

jonasfj opened this issue Oct 25, 2021 · 3 comments
Labels
enhancement New feature or request pkg:shelf_router Package shelf_router

Comments

@jonasfj
Copy link
Member

jonasfj commented Oct 25, 2021

We could use the same pattern as UrlPattern.

This would be a breaking change... It's possible we could make a deprecated API or something else for use the old syntax.
@jonasfj jonasfj added enhancement New feature or request pkg:shelf_router Package shelf_router labels Oct 25, 2021
@mark-dropbear
Copy link

I just came to file this as a feature request. I think it's a great idea now that browsers and other languages are starting to standardize around this.

@mark-dropbear
Copy link

Just for reference this should be helpful https://wicg.github.io/urlpattern/#urlpattern

@jonasfj jonasfj mentioned this issue Mar 23, 2022
Closed
@jonasfj
Copy link
Member Author

jonasfj commented Mar 23, 2022

If someone wants to work on this I'm happy to review PRs, just make sure the CC @jonasfj on PRs.

Maybe it even makes sense for dart-neats to contain a package that does UrlPattern matching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request pkg:shelf_router Package shelf_router
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonasfj @mark-dropbear