Skip to content

Commit e44868c

Browse files
kevinoconnor7Error Prone Team
authored andcommitted
Remove checkSwitchExpressionsWithDefaultForSkew flag as it's now enabled by default.
PiperOrigin-RevId: 764795853
1 parent 95c80bf commit e44868c

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

core/src/main/java/com/google/errorprone/bugpatterns/MissingCasesInEnumSwitch.java

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import com.google.common.collect.ImmutableSet;
2424
import com.google.common.collect.Sets;
2525
import com.google.errorprone.BugPattern;
26-
import com.google.errorprone.ErrorProneFlags;
2726
import com.google.errorprone.VisitorState;
2827
import com.google.errorprone.bugpatterns.BugChecker.SwitchExpressionTreeMatcher;
2928
import com.google.errorprone.bugpatterns.BugChecker.SwitchTreeMatcher;
@@ -39,7 +38,6 @@
3938
import java.util.Optional;
4039
import java.util.Set;
4140
import java.util.stream.Collectors;
42-
import javax.inject.Inject;
4341
import javax.lang.model.element.ElementKind;
4442

4543
/** A {@link BugChecker}; see the associated {@link BugPattern} annotation for details. */
@@ -50,16 +48,6 @@ public class MissingCasesInEnumSwitch extends BugChecker
5048
implements SwitchTreeMatcher, SwitchExpressionTreeMatcher {
5149
public static final int MAX_CASES_TO_PRINT = 5;
5250

53-
private final boolean checkSwitchExpressionsWithDefaultForSkew;
54-
55-
@Inject
56-
MissingCasesInEnumSwitch(ErrorProneFlags flags) {
57-
this.checkSwitchExpressionsWithDefaultForSkew =
58-
flags
59-
.getBoolean("MissingCasesInEnumSwitch:CheckSwitchExpressionsWithDefaultForSkew")
60-
.orElse(true);
61-
}
62-
6351
@Override
6452
public Description matchSwitch(SwitchTree tree, VisitorState state) {
6553
ExpressionTree expression = tree.getExpression();
@@ -87,12 +75,6 @@ public Description matchSwitch(SwitchTree tree, VisitorState state) {
8775

8876
@Override
8977
public Description matchSwitchExpression(SwitchExpressionTree tree, VisitorState state) {
90-
// Javac will check for exhaustiveness; the only reason we would check is if there's a default
91-
// only intended for version skew.
92-
if (!checkSwitchExpressionsWithDefaultForSkew) {
93-
return Description.NO_MATCH;
94-
}
95-
9678
ExpressionTree expression = tree.getExpression();
9779
List<? extends CaseTree> cases = tree.getCases();
9880
Type switchType = ASTHelpers.getType(expression);

0 commit comments

Comments
 (0)