Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JDK 17 and other related version upgrades #155

Closed
vivekmittal07 opened this issue Apr 25, 2023 · 7 comments · Fixed by #310
Closed

Upgrade to JDK 17 and other related version upgrades #155

vivekmittal07 opened this issue Apr 25, 2023 · 7 comments · Fixed by #310
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers P1:must As issue that definitely needs to be implemented in near future.

Comments

@vivekmittal07
Copy link
Collaborator

We need to upgrade the spring-boot.version from 2.7.5 to 3.0.6.
This requires us to upgrade to java17.

We should also make all other upgrade PRs created by dependabot

@bashir2
Copy link
Collaborator

bashir2 commented Apr 26, 2023

Just to add some context here: Beside dealing with the usual dependabot alerts/PRs for version upgrades, another motivation for Spring version upgrade is this security vulnerability which is CVE-2016-1000027. I have not investigated the details but if switching to Spring 6+ is a major issue (e.g., for our usage of HAPI) then we may want to look at details of the vulnerability and decide whether to do the upgarde or not.

@bashir2
Copy link
Collaborator

bashir2 commented Apr 26, 2023

BTW, @vivekmittal07 the issues that you are facing with HAPI might be due to the javax to jakarta namespace migration as described here.

@vivekmittal07
Copy link
Collaborator Author

Thanks Bashir!

Issue after upgrading the dependency - None of the servlets seem to be loading. For any FHIR endpoint server throws Not Found exception.

@bashir2 Like you mentioned the issue is due to migration to jakarta namespace.
There is an open issue on HAPI Fhir server for this - hapifhir/hapi-fhir#2082
There is significant interest in the community and they should update the timelines soon - hapifhir/hapi-fhir#2082 (comment)

Till this is fixed I think we can't upgrade the spring version. I will look at the vulnerability and see if this impacts us and what are the mitigation steps.

@vivekmittal07
Copy link
Collaborator Author

This vulnerability was found in the Spring Remoting technologies -
spring-projects/spring-framework#25379
https://docs.spring.io/spring-framework/docs/3.2.0.M2/reference/html/remoting.html

They seem to have deprecated the following packages - spring-projects/spring-framework#25379 (comment)

HAPI should not be using any of these remoting technologies as it just provides a framework to create a FHIR server.
To confirm I downloaded the HAPI source code and ran the following to look for any import dependancy on the impacted libraries -

  • grep "org.springframework.remoting" -R .
  • grep "org.springframework.jms.remoting" -R .
    There were no references in the source code.

Search for "phasing out serialization-based remoting" in https://docs.spring.io/spring-framework/docs/5.3.15/javadoc-api/deprecated-list.html. This shows list of impacted packages.
Above search looks for dependency on these packages.

I think it is safe to say that the vulnerability doesn't affect us.
@bashir2 Ptal and let me know what you think.

@vivekmittal07
Copy link
Collaborator Author

We cannot migrate to new spring version unless Hapi does the migration - hapifhir/hapi-fhir#2082
The vulnerability reported in Spring should not affect as explained in #155 (comment).

We will not do the migration to new Spring version.

@bashir2
Copy link
Collaborator

bashir2 commented Jul 4, 2023

Reopening this issue to revisit once HAPI does the same upgrade (details).

@bashir2 bashir2 reopened this Jul 4, 2023
@bashir2 bashir2 added enhancement New feature or request good first issue Good for newcomers P2:should An issue to be addressed in a quarter or so. labels May 7, 2024
@bashir2
Copy link
Collaborator

bashir2 commented May 7, 2024

Now that hapifhir/hapi-fhir#2082 is fixed and HAPI 7.0 is released we should do the various version upgrades mentioned in this issue (that were blocked before).

@bashir2 bashir2 self-assigned this Oct 4, 2024
@bashir2 bashir2 added P1:must As issue that definitely needs to be implemented in near future. and removed P2:should An issue to be addressed in a quarter or so. labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers P1:must As issue that definitely needs to be implemented in near future.
Projects
None yet
2 participants