Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support csharp_partial for unions #8440

Open
inikulshin opened this issue Nov 13, 2024 · 0 comments
Open

Support csharp_partial for unions #8440

inikulshin opened this issue Nov 13, 2024 · 0 comments

Comments

@inikulshin
Copy link

inikulshin commented Nov 13, 2024

E.g.

union ArgumentValue (csharp_partial) {
  ArgumentValueString,
  ArgumentValueArrayByte,
  ArgumentValueNumber,
  ArgumentValueBoolean,
  ArgumentValueList
}

Firstly it's just a better design, to allow csharp_partial for all generated classes, without exception.

But it may be useful for defining more brief constructors:

public ArgumentValueUnion(string value)
{
    Value = ArgumentValueUnion.FromArgumentValueString(new ArgumentValueStringT { Value = value });
}

or overriding ToString():

public override string ToString()
{
    switch ...
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant