Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Iansui #7742

Open
9 tasks done
ButTaiwan opened this issue May 17, 2024 · 6 comments · May be fixed by #8590
Open
9 tasks done

Add Iansui #7742

ButTaiwan opened this issue May 17, 2024 · 6 comments · May be fixed by #8590
Assignees
Labels
-- Needs confirmation from upstream or onboarder I New Font II CJK Chinese, Japanese, Korean scripts II Submission pending proposal for non-commissioned fonts suggested in the issue tracker P2
Milestone

Comments

@ButTaiwan
Copy link

ButTaiwan commented May 17, 2024

Font Project Git Repo URL:
https://github.com/ButTaiwan/iansui

Super short description of the Font Family:

  • Iansui is a Traditional Chinese font, which is divided from Klee One Project.
  • Iansui complies with the font specifications of Taiwan's Ministry of Education and is suitable for education and school-age reading.
  • Iansui supports Taiwanese, Hakka Chinese characters, and phonetic symbols of Taiwanese, Hakka, and aboriginal languages.

Requirements:

Google Fonts will publish only fonts that match its requirements. Please familiarize yourself with the complete documentation in the Google Fonts Guide (GF-Guide) and ensure your font project complies with them before submitting the font family. You can also use the Google Fonts Project Template, which will help you create a repository that follows the needed structure and includes build requirements.

By filling this issue, you can confirm the project meets the requirements (by ticking the cases or putting x between the square brackets in text mode):

  • I read, agree, and comply with the full contributing requirements
  • The entire font project is licensed under the OFL
  • There is no "Reserved Font Name" mention in the OFL license
  • Family name is unique according to namecheck.fontdata.com
  • The font supports at least GF Latin Core glyphset
  • The repository respect the upstream repo structure
  • The source files are available in the repository
  • I am the author of the font, or the author agreed to this submission
  • I will maintain the repository and participate in the onboarding process (addressing, solving, and responding to issues, merging pull requests, etc)

Image:

image

Attach here a pic or a screenshot of the font. One image is enough, it can be a few letters, to give a quick overview.

@ButTaiwan ButTaiwan added I New Font II Submission pending proposal for non-commissioned fonts suggested in the issue tracker labels May 17, 2024
ronaldtse added a commit to fontist/formulas that referenced this issue May 27, 2024
ronaldtse added a commit to fontist/formulas that referenced this issue May 27, 2024
@vv-monsalve vv-monsalve added the II CJK Chinese, Japanese, Korean scripts label May 28, 2024
@vv-monsalve vv-monsalve added this to the Submissions to review milestone May 28, 2024
@vv-monsalve
Copy link
Collaborator

Hi @ButTaiwan, thanks for your submission! We'll go over it in our next intake meeting and let you know about its approval. :)

@aaronbell
Copy link
Collaborator

Hi there. The OFL license file in the repository states with Reserved Font Name "芫荽". Our preference is no RFN, per the submission guidelines. @ButTaiwan Please advise.

@vv-monsalve vv-monsalve added the -- Needs confirmation from upstream or onboarder label Nov 13, 2024
@vv-monsalve
Copy link
Collaborator

@ButTaiwan could you please confirm about the RFN?

@ButTaiwan
Copy link
Author

@ButTaiwan could you please confirm about the RFN?

I thought that Chinese font names are not included in Google Fonts subsets, so I just removed the English name Iansui from RFN.
I can change it in the next version if it is necessary.

@aaronbell
Copy link
Collaborator

IMO, it is a little odd to have an RFN for the name in Chinese characters but not for the name in Latin. Feels like the same name either way. I’d say either remove it, or get a license agreement in place with GF.

Also? GF will require name table ID 1 to be in Latin characters, so the Chinese name needs to be moved to a localized string anyway. If you’re OK with the overall removal of the RFN, then I’ll remove it across the board so we can move forward without it.

@ButTaiwan
Copy link
Author

If you’re OK with the overall removal of the RFN, then I’ll remove it across the board so we can move forward without it.

It's OK.

@aaronbell aaronbell linked a pull request Nov 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Needs confirmation from upstream or onboarder I New Font II CJK Chinese, Japanese, Korean scripts II Submission pending proposal for non-commissioned fonts suggested in the issue tracker P2
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

4 participants