Building on kernel 6.12 fails (error: ‘no_llseek’ undeclared)

[claymen]

This has broken with Kernel 6.12 and looks to be related to this existing pull request #35

DKMS make.log for gasket-1.0 for kernel 6.12.0-custom(x86_64)
Mon Nov 18 01:51:31 PM AWST 2024
make: Entering directory '/usr/src/linux-headers-6.12.0-custom'
  CC [M]  /var/lib/dkms/gasket/1.0/build/gasket_core.o
  CC [M]  /var/lib/dkms/gasket/1.0/build/gasket_ioctl.o
  CC [M]  /var/lib/dkms/gasket/1.0/build/gasket_interrupt.o
  CC [M]  /var/lib/dkms/gasket/1.0/build/gasket_page_table.o
  CC [M]  /var/lib/dkms/gasket/1.0/build/gasket_sysfs.o
  CC [M]  /var/lib/dkms/gasket/1.0/build/apex_driver.o
/var/lib/dkms/gasket/1.0/build/gasket_core.c:1376:19: error: ‘no_llseek’ undeclared here (not in a function); did you mean ‘noop_llseek’?
 1376 |         .llseek = no_llseek,
      |                   ^~~~~~~~~
      |                   noop_llseek
make[2]: *** [scripts/Makefile.build:229: /var/lib/dkms/gasket/1.0/build/gasket_core.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/usr/src/linux-headers-6.12.0-custom/Makefile:1936: /var/lib/dkms/gasket/1.0/build] Error 2
make: *** [Makefile:224: __sub-make] Error 2
make: Leaving directory '/usr/src/linux-headers-6.12.0-custom'

[claymen]

And for reference, the pull request linked does resolve the issue, so if you are seeing this then grab that version or modify your local version with the same changes.

[mwprado]

Hi,

"no_llseek" was removed in kernel. Could you use this patch in "gasket_core.c" for kernel 6.12?

#if LINUX_VERSION_CODE < KERNEL_VERSION(6, 12, 0)
/* no_llseek by default introduced at v2.6.37-rc1 and
 * removed in 6.12.0
 */
.llseek = no_llseek,
#endif

[mirage335]

Seems deleting that line from 'gasket_core.c' was able to get the compile to proceed and the Debian package install to claim success.

---

git clone https://github.com/google/gasket-driver.git
cd gasket-driver/src

# ... delete line mentioning '.llseek' from 'gasket_core.c'

cd ..
# assume Linux headers are already present of course
sudo apt-get install dkms devscripts debhelper dh-dkms build-essential
debuild -us -uc -tc -b
sudo dpkg -i ../gasket-dkms*.deb

# ATTRIBUTION-AI ChatGPT 40 2025-01-08 ... helped find this repository and suggested some relevant commands for compiling

[chrBrd]

Seems deleting that line from 'gasket_core.c' was able to get the compile to proceed and the Debian package install to claim success.

Yep - if you have this problem delete line 1376:

.llseek = no_llseek,

in gasket_core.c.

As @claymen mentioned, this should hopefully get fixed if #35 gets merged.

The if conditional is only there for backwards compatibilty though - if you're seeing this error just deleting that line is an easier solution than patching #35.

[grigio]

@chrBrd thanks it worked. It's so sad that at every kernel update this driver is broken :(